-
Notifications
You must be signed in to change notification settings - Fork 37
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Scroll optimize #162
Scroll optimize #162
Conversation
NOTE: this commit breaks scrolling-related features, i.e. scroll-to-bottom and locating at specific floor
…_list to provide better experience when locating and scrolling to the bottom NOTE: this commit breaks all ScrollBars on paged_listview.
…into scroll-optimize
Until we figure out a fix to all broken features (i.e. ScrollBar cannot scroll, double tap on title cannot jump to the top), this PR should not be merged. |
…formance since keframe is removed to prevent locating issues Note: 1. ScrollBar still meets with error after entering hole_detail with locating to certain posts. Also, its performance on iOS is not tested; 2. TopController should be replaced with TopPositionedController in pages with PagedListView now.
There are some problems preventing this merge:
However, removing What do you think towards these problems? @singularity-s0 p.s. I think that Flutter is really doing a bad job with scrolling things. We have struggled with |
Is it possible to use |
Looks hopeful. You can start a new branch and do some tests on it. |
Tests complete. You may revert to the previous implementation and merge these branches. |
The PR and the branch is verified as unworkable. Close it. |
Shall we have a try on https://github.com/superlistapp/super_sliver_list? It looks promising. Edit: also see https://github.com/fzyzcjy/flutter_smooth. |
Still need to: