Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

首次使用「日程」页面时,提供功能展示 #275

Merged
merged 9 commits into from
Aug 7, 2023

Conversation

cryindevil
Copy link
Collaborator

实现首次使用「日程」页面时,提供功能展示
注:是旦夕app下载后第一次切换到日程页面时才会打开,要再次看到只有卸载重新下载才会看到。
在开发过程中往本地仓库提交了两次,用的提交备注显得很意义不明,下一次会注意的。
(提交当中有几处无意义的改动我估计是vsode自动的格式调整,应该没事吧?)

Copy link
Member

@w568w w568w left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Commit message 请参考 https://ruby-china.org/topics/15737readyfinal 这样语焉不详的一个单词是不被允许的。如果不知道如何修改已有的 commit message,参考这个手册

此外还有如下问题,建议逐一核实和修改。

flutter_01.png Outdated Show resolved Hide resolved
flutter_02.png Outdated Show resolved Hide resolved
lib/l10n/intl_en.arb Outdated Show resolved Hide resolved
lib/l10n/intl_ja.arb Outdated Show resolved Hide resolved
lib/page/subpage_timetable.dart Outdated Show resolved Hide resolved
lib/page/subpage_timetable.dart Outdated Show resolved Hide resolved
lib/page/subpage_timetable.dart Outdated Show resolved Hide resolved
lib/provider/settings_provider.dart Outdated Show resolved Hide resolved
pubspec.lock Outdated Show resolved Hide resolved
@cryindevil
Copy link
Collaborator Author

cryindevil commented Aug 6, 2023

如果全为机翻的话,建议是不如不添加日语。

已设置为英语

建议统一用 Semester。

已改

要延迟到下一帧显示,应该使用 [WidgetsBinding.instance.addPostFrameCallback]

最初我的想法是给用户一定时间看一下,但我后来觉得意义不大就设置成0,现在我设置为直接调用showTutorial()

因为 tutorialCoachMark 本身只在 initState 里用到,这里应该无需作为一个类的字段存储。

tutorialCoachMark 并非只在initState里用到,initstate中只是调用了createTutorial()和showTutorial()而这两个函数体中依赖于tutorialCoachMark (这两个函数于initstate是同一级定义的)

这里为什么要把同一段话复制粘贴三遍?

这里不是同一段话,因为tutorial包围了三个button,这里是分别对三个button添加到聚焦的目标里,从identify和keyTarget可以看出

Visited 拼写错误。

已改

不要推送含有镜像源 flutter-io.cn 的 pubspec.lock 上去

已改,我复制粘贴了旦夕仓库中pubspec.lock内容提交了进去

@cryindevil cryindevil requested a review from w568w August 6, 2023 03:35
@w568w
Copy link
Member

w568w commented Aug 6, 2023

不用一一回复,更好的做法是 Resolve 掉对应的 Conversation。

lib/l10n/intl_ja.arb Outdated Show resolved Hide resolved
lib/page/subpage_timetable.dart Outdated Show resolved Hide resolved
Copy link
Member

@w568w w568w left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

这里也可以改一下。

lib/page/subpage_timetable.dart Outdated Show resolved Hide resolved
Copy link
Member

@w568w w568w left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@w568w w568w linked an issue Aug 7, 2023 that may be closed by this pull request
5 tasks
@w568w w568w linked an issue Aug 7, 2023 that may be closed by this pull request
@w568w w568w merged commit 60a8da7 into DanXi-Dev:main Aug 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

首次使用「日程」页面时,提供功能展示
2 participants