-
Notifications
You must be signed in to change notification settings - Fork 37
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
首次使用「日程」页面时,提供功能展示 #275
首次使用「日程」页面时,提供功能展示 #275
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Commit message 请参考 https://ruby-china.org/topics/15737,ready
和 final
这样语焉不详的一个单词是不被允许的。如果不知道如何修改已有的 commit message,参考这个手册。
此外还有如下问题,建议逐一核实和修改。
…Xi-Dev#275 Basically done, except language part
…Xi-Dev#275 first pull request attempt
…Xi-Dev#275 second pull request attempt
restore pubspec.lock
已设置为英语
已改
最初我的想法是给用户一定时间看一下,但我后来觉得意义不大就设置成0,现在我设置为直接调用showTutorial()
tutorialCoachMark 并非只在initState里用到,initstate中只是调用了createTutorial()和showTutorial()而这两个函数体中依赖于tutorialCoachMark (这两个函数于initstate是同一级定义的)
这里不是同一段话,因为tutorial包围了三个button,这里是分别对三个button添加到聚焦的目标里,从identify和keyTarget可以看出
已改
已改,我复制粘贴了旦夕仓库中pubspec.lock内容提交了进去 |
不用一一回复,更好的做法是 Resolve 掉对应的 Conversation。 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
这里也可以改一下。
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
实现首次使用「日程」页面时,提供功能展示
注:是旦夕app下载后第一次切换到日程页面时才会打开,要再次看到只有卸载重新下载才会看到。
在开发过程中往本地仓库提交了两次,用的提交备注显得很意义不明,下一次会注意的。
(提交当中有几处无意义的改动我估计是vsode自动的格式调整,应该没事吧?)