Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[charts/redis-ha] Add disableAPICheck to skip api checks for servicemonitor #278

Merged
merged 12 commits into from
Nov 6, 2024

Conversation

psychomantys
Copy link
Contributor

@psychomantys psychomantys commented May 19, 2024

What this PR does / why we need it:

This helm attempts to verify the API version during deployment processes. However, in some environments, direct access to the API is not available beforehand, which complicates the deployment.

This situation is particularly problematic in two notable scenarios:

  • Offline Manifest Generation and Application: When the manifests are generated in one environment (e.g., a CI/CD pipeline or a local machine) and then applied to another cluster, there's no way to verify the API version during the generation phase.
  • Manifest Generation Using Kustomize: In environments where manifests are created using tools like kustomize, the version check becomes redundant and can lead to deployment issues.

My PR proposes modifications that bypass the API version check under these specific conditions, ensuring smoother and more flexible deployments in environments lacking direct API connectivity.

Checklist

  • DCO signed
  • Chart Version bumped
  • Variables are documented in the README.md
  • Title of the PR starts with chart name (e.g. [stable/mychartname])

@DandyDeveloper
Copy link
Owner

@psychomantys Can we get a patch bump and pull in the latest master branch?

@psychomantys
Copy link
Contributor Author

@DandyDeveloper Something like that?

DandyDeveloper
DandyDeveloper previously approved these changes Nov 6, 2024
Signed-off-by: Aaron Layfield <[email protected]>
@DandyDeveloper DandyDeveloper merged commit ef60e7b into DandyDeveloper:master Nov 6, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants