Use product-specific USB descriptor string for Product
#137
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
henrygab
force-pushed
the
usb_descriptors_strings
branch
from
686cb31 to
b3dd1df
Compare
It was dead code anyways, but also had a number of bugs. Not good.
henrygab
force-pushed
the
usb_descriptors_strings
branch
from
b3dd1df to
4c1fc72
Compare
DangerousPrototypes
merged commit 664f569
into
DangerousPrototypes:main
4 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I have installed firmware build via the GitHub actions on:
This firmware appears to work without issue on at least Windows 11, including after using USBDeview.exe to uninstall all prior instances of the buspirate VID/PID.
Ian ... can you please review for unintended side effects, and merge if you are happy with it?