New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix trailing member/call behavior #1609

Merged

edemaine merged 1 commit into main from trailing-call

Nov 18, 2024

Collaborator

edemaine commented Nov 18, 2024

Fixes @bbrk24's reported regression (which is now a test).

Call arguments now check for trailing call expressions instead of trailing member expressions.
I never understood why we had both trailing member and trailing call rules. We no longer use the member ones, so the grammar got a bunch simpler.
Missing .flat() in handling trailing call expressions (else a JSX test would fail).


          Fix trailing member/call behavior

99a26cb

edemaine temporarily deployed to build

November 18, 2024 22:04

— with

GitHub Actions Inactive

STRd6 approved these changes

View reviewed changes

Contributor

STRd6 left a comment

Thanks, glad to see things getting simpler!

edemaine merged commit ac96deb into main

3 of 4 checks passed

edemaine deleted the trailing-call branch

November 18, 2024 22:29

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet