Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

""" interpolations require coffeeInterpolation, /// respects coffeeInterpolation, coffeeComment, coffeeDiv #1635

Merged
merged 1 commit into from
Dec 5, 2024

Conversation

edemaine
Copy link
Collaborator

@edemaine edemaine commented Dec 5, 2024

  • Bring """ strings into alignment with " strings: #{expr} interpolation is supported only when coffeeInterpolation is set. Use ``` and ${expr} to interpolate
  • Bring /// regexes into alignment with this: #{expr} interpolation is supported only when coffeeInterpolation is set. Use ${expr} interpolation instead.
  • Fix a bug where ///foo${expr}/// did not interpolate
  • Change comment behavior in ///:
    • # is a comment only when coffeeComment is enabled
    • // is a comment only when coffeeDiv is disabled (the idea is that coffeeDiv sacrifices // working as a comment)

BREAKING CHANGE: """ and /// no longer support #{expr} interpolation unless you set coffeeInterpolation; /// no longer supports # comments without coffeeComment; /// no longer supports // comments with coffeeDiv

Copy link
Contributor

@STRd6 STRd6 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Definitely better to get this sorted out now rather than years from now.

@edemaine edemaine merged commit 1a40ed9 into main Dec 5, 2024
4 checks passed
@edemaine edemaine deleted the coffee-interpolate-comment branch December 5, 2024 18:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants