Fat pipe ||> uses semicolons at statement level
#1636
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
STRd6
approved these changes
Dec 5, 2024
source/parser/function.civet
Outdated
| when "PipelineExpression" | ||
| // At statement level, pipeline generates semicolons between statements | ||
| // Return the last one | ||
| semi := exp.children.indexOf ";" |
There was a problem hiding this comment.
Should this be lastIndexOf or is it always only going to have one?
There was a problem hiding this comment.
Indeed! Thanks for catching!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1339
Functionally equivalent, but good for linting. Also generates somewhat nicer looking code, because implicit
returns get moved to the end of a chain.It was a little trickier than the idea in #1339 (comment) because of implicit returns.