-
Notifications
You must be signed in to change notification settings - Fork 34
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Reference #685
Conversation
Thanks for changing this. I wonder if there's a way to make the old cheatsheet link redirect (for now), so that old links aren't broken? Until we have a new cheatsheet. |
I'll try and add a new actual cheatsheet to this PR tomorrow. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry, I realize I never reviewed the cheatsheet. It looks great!! Just a couple comments.
I think we've reached too much stuff in the navbar. At some smaller screen widths, Getting started line-breaks (but before it's small enough to trigger a navbar menu):
Maybe we should drop Config? It doesn't actually say much, though it probably should...
We could also deal with this layout issue later. It's important to get this merged before we need to change any docs.
When every property has a value, braces can be omitted. | ||
for own key in object | ||
log `my ${key}` | ||
``` |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I might add the two-binding forms of for..of/in
. Not sure whether to modify the existing examples or add them separately.
Co-authored-by: Erik Demaine <[email protected]>
Moved cheatsheet to reference.
I also tried to update vitepress but ran into some trouble. In the updated version they were sticklers about .js and .mjs so that's why I renamed those as well as I may try to update again in the future.