Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reference #685

Merged
merged 5 commits into from
Sep 9, 2023
Merged

Reference #685

merged 5 commits into from
Sep 9, 2023

Conversation

STRd6
Copy link
Contributor

@STRd6 STRd6 commented Sep 1, 2023

Moved cheatsheet to reference.

I also tried to update vitepress but ran into some trouble. In the updated version they were sticklers about .js and .mjs so that's why I renamed those as well as I may try to update again in the future.

@STRd6 STRd6 temporarily deployed to build September 1, 2023 19:32 — with GitHub Actions Inactive
@STRd6 STRd6 temporarily deployed to build September 1, 2023 19:34 — with GitHub Actions Inactive
@edemaine
Copy link
Collaborator

edemaine commented Sep 2, 2023

Thanks for changing this. I wonder if there's a way to make the old cheatsheet link redirect (for now), so that old links aren't broken? Until we have a new cheatsheet.

@STRd6
Copy link
Contributor Author

STRd6 commented Sep 3, 2023

I'll try and add a new actual cheatsheet to this PR tomorrow.

@STRd6 STRd6 temporarily deployed to build September 3, 2023 17:03 — with GitHub Actions Inactive
@STRd6 STRd6 temporarily deployed to build September 3, 2023 18:27 — with GitHub Actions Inactive
@STRd6 STRd6 temporarily deployed to build September 3, 2023 22:35 — with GitHub Actions Inactive
Copy link
Collaborator

@edemaine edemaine left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry, I realize I never reviewed the cheatsheet. It looks great!! Just a couple comments.

I think we've reached too much stuff in the navbar. At some smaller screen widths, Getting started line-breaks (but before it's small enough to trigger a navbar menu):

image

Maybe we should drop Config? It doesn't actually say much, though it probably should...

We could also deal with this layout issue later. It's important to get this merged before we need to change any docs.

civet.dev/cheatsheet.md Outdated Show resolved Hide resolved
When every property has a value, braces can be omitted.
for own key in object
log `my ${key}`
```
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I might add the two-binding forms of for..of/in. Not sure whether to modify the existing examples or add them separately.

@STRd6 STRd6 temporarily deployed to build September 9, 2023 19:07 — with GitHub Actions Inactive
@STRd6 STRd6 merged commit 5291ec2 into main Sep 9, 2023
2 checks passed
@STRd6 STRd6 deleted the reference branch September 9, 2023 20:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants