[DT-1122] Apply zizmor suggestions
#1733
Open
+19
−6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fboulnois
requested review from
pshapiro4broad and
snf2ye
and removed request for
a team
|
jade-data-repo-ui
|
||||||||||||||||||||||||||||
| Project |
jade-data-repo-ui
|
| Branch Review |
fb-dt-1122-apply-zizmor-fixes
|
| Run status |
|
| Run duration | 02m 51s |
| Commit |
|
| Committer | fboulnois |
| View all properties for this run ↗︎ | |
| Test results | |
|---|---|
Failures
|
0
|
Flaky
|
0
|
Pending
|
0
|
Skipped
|
0
|
Passing
|
17
|
| View all changes introduced in this branch ↗︎ | |
snf2ye
reviewed
Jan 9, 2025
Comment on lines
-72
to
+89
| docker build -t gcr.io/${{ env.gcr_google_project }}/jade-data-repo-ui:${GCR_TAG} --build-arg CACHEBUST=$(date +%s) . | ||
| docker build -t gcr.io/${gcr_google_project}/jade-data-repo-ui:${GCR_TAG} --build-arg CACHEBUST=$(date +%s) . | ||
| # Push the Docker image to Google Container Registry | ||
| - name: Publish and tag new docker container to GCR | ||
| run: | | ||
| gcloud auth activate-service-account --key-file jade-dev-account.json | ||
| gcloud auth configure-docker --quiet | ||
| docker push gcr.io/${{ env.gcr_google_project }}/jade-data-repo-ui:${GCR_TAG} | ||
| docker push gcr.io/${gcr_google_project}/jade-data-repo-ui:${GCR_TAG} | ||
| gcloud container images \ | ||
| add-tag \ | ||
| gcr.io/${{ env.gcr_google_project }}/jade-data-repo-ui:"${GCR_TAG}" \ | ||
| gcr.io/${{ env.gcr_google_project }}/jade-data-repo-ui:"${{ steps.uiprevioustag.outputs.tag }}" --quiet | ||
| gcr.io/${gcr_google_project}/jade-data-repo-ui:"${GCR_TAG}" \ | ||
| gcr.io/${gcr_google_project}/jade-data-repo-ui:"${PREV_TAG}" --quiet | ||
| gcloud container images \ | ||
| add-tag \ | ||
| gcr.io/${{ env.gcr_google_project }}/jade-data-repo-ui:"${GCR_TAG}" \ | ||
| gcr.io/${{ env.gcr_google_project }}/jade-data-repo-ui:"${GCR_TAG}-develop" --quiet | ||
| gcr.io/${gcr_google_project}/jade-data-repo-ui:"${GCR_TAG}" \ | ||
| gcr.io/${gcr_google_project}/jade-data-repo-ui:"${GCR_TAG}-develop" --quiet | ||
| env: | ||
| PREV_TAG: ${{ steps.uiprevioustag.outputs.tag }} |
There was a problem hiding this comment.
Were you able to test these changes? I'm a little worried that it won't pick up on these variables with the changes - I've found it to be really picky in the past.
I think I've been able to test a subset of this action by commenting out the bumperstep, helm_tag_bump an cherry_pick_image_to_production_gcr tasks and then kicking off the run on your branch.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses
https://broadworkbench.atlassian.net/browse/DT-1122
Summary