Align Glue component with Iberia deployment #25
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
callarelli93
commented
Sep 19, 2024
callarelli93
commented
- Configure Glue component like the Iberia deployment
- Choose sensible defaults
callarelli93
changed the title
kkiani
reviewed
Sep 20, 2024
kkiani
reviewed
Sep 20, 2024
| else f"s3://{self.code_repository_bucket}/{job.name}.py" | ||
|
|
||
| @staticmethod | ||
| def __get_default_arguments(job: GlueJobDefinition) -> dict[str, str]: |
There was a problem hiding this comment.
@callarelli93 same as __create_glue_trigger
There was a problem hiding this comment.
Also, why are you defining it as a staticmethod?
There was a problem hiding this comment.
Because it's not depending on any other method or properties
kkiani
reviewed
Sep 20, 2024
Comment on lines
74
to
126
| """ | ||
| Glue job definitions and infrastructure dependencies such as IAM roles, external connections, code and data storage. | ||
|
|
||
| :param jobs: the list of GlueJobDefinition to deploy | ||
| :param execution_role: the IAM role attached to the Glue jobs if it exists, if not one will be createdw | ||
| :param database_name: name of the Glue database if it exists, if not one will be created | ||
| :param code_repository_bucket_name: name of the s3 code repository database if it exists, if not one will be created | ||
| :param data_bucket_name: name of the s3 bucket to store data, if it exists, if not one will be created | ||
| :param kafka_checkpoints_bucket_name: name of the s3 bucket to store checkpoints if it exists, if not one will be created | ||
| """ |
There was a problem hiding this comment.
@callarelli93 we should also decide on the docstring standards and use one standard everywhere. The only important thing in choosing the standard is how well the standard is supported with MKDocs.
There was a problem hiding this comment.
@kkiani In Inception, we agreed to continue with Google Style. I fixed all of the comments to be Google Style compatible.
kkiani
reviewed
Sep 20, 2024
6 tasks
kkiani
force-pushed
the
main
branch
2 times, most recently
from
82eeb76 to
da63efe
Compare
farbodahm
force-pushed
the
feat/aws-spark-app-on-glue
branch
from
5fa9c6d to
a20022f
Compare
kkiani
reviewed
Oct 10, 2024
farbodahm
force-pushed
the
feat/aws-spark-app-on-glue
branch
from
ffa6826 to
e5730f8
Compare
kkiani
reviewed
Oct 11, 2024
kkiani
approved these changes
Oct 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.