feat: improving obj storage #7
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shahinism
approved these changes
Aug 1, 2024
kkiani
force-pushed
the
feature/improving-obj-storage
branch
from
c9bae77 to
4e8e61a
Compare
kkiani
force-pushed
the
feature/improving-obj-storage
branch
from
4e8e61a to
17c918d
Compare
All the exceptions wrapping boto3 ClientError with set the ClientError as their root cause
providers arguments were not directly available due to design of pulumi. This solution creates defautl wapper around pulumi providers to keep contexts.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Object storages are very basic requirements in many complex application. The previous implementation was just focusing on providing a few methods without any tests to POC the framework. This PR added all the basic functionality that is required.