Rename env variables to follow DataDog profiling naming conventions #17
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nsavoire
force-pushed
the
nsavoire/rename_env_variables
branch
from
e5bb572 to
84e28d3
Compare
Gandem
reviewed
Sep 27, 2024
nsavoire
force-pushed
the
nsavoire/opensource
branch
3 times, most recently
from
03bc08a to
5d65481
Compare
An error occurred while trying to automatically change base from
nsavoire/opensource
to
main
September 27, 2024 13:51
nsavoire
force-pushed
the
nsavoire/rename_env_variables
branch
2 times, most recently
from
cec9b46 to
4e14904
Compare
![datadog-datadog-prod-us1[bot]](https://avatars.githubusercontent.com/u/365230?s=60&v=4){kind=small}
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
nsavoire
force-pushed
the
nsavoire/rename_env_variables
branch
3 times, most recently
from
a708aa0 to
2d669ba
Compare
r1viollet
reviewed
Oct 9, 2024
|
I think we left things on whether to namespace or not some of these variables. The thought was that:
|
nsavoire
force-pushed
the
nsavoire/rename_env_variables
branch
3 times, most recently
from
0212176 to
7635875
Compare
nsavoire
force-pushed
the
nsavoire/rename_env_variables
branch
2 times, most recently
from
e4e3270 to
56ac5bc
Compare
r1viollet
reviewed
Oct 28, 2024
r1viollet
reviewed
Oct 29, 2024
Gandem
reviewed
Nov 4, 2024
Gandem
reviewed
Nov 4, 2024
GOPATH is set to /go by parent image, which makes it unusable by non-root users. Unset it to make Go tools work for non-root users.
Use DD_TRACE_AGENT_URL instead of DD_AGENT_URL
nsavoire
force-pushed
the
nsavoire/rename_env_variables
branch
from
acbc8f8 to
c25d41e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Rename env variables used for configuration to be consistent with other Datadog profilers (eg
DD_SERVICE,DD_PROFILING_UPLOAD_PERIOD).Also add a prefixed version of these variables (eg
DD_HOST_SERVICE,DD_HOST_PROFILING_UPLOAD_PERIOD) that takes precedence over the non-prefixed version for cases where host profiler might be running along side another runtime profiler and a different configuration is needed for the host profiler.