containermetadata: make default pattern more restrictive #39
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nsavoire
approved these changes
Nov 13, 2024
the default pattern would match systemd service names which only contain letter a-f (see added test which fails with the current code) this commit extracts the container regex pattern used by the datadog-agent, and uses it as a default pattern. this makes the pattern more restrictive, avoiding the addition of an incorrect container_id tags for some systemd services
Gandem
force-pushed
the
nayef/fix-default-pattern
branch
from
0a99c7f to
0f9f30c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
The existing default pattern would match systemd service names which only contain letter a-f (see added test which fails with the current code).
This commit extracts the container regex pattern used by the datadog-agent, and uses it as a default pattern.
This makes the pattern more restrictive, avoiding the addition of an incorrect container_id tags for some systemd services.
Motivation
Profiles contained an incorrect container id, with the example added in the test.
Additional Notes
N/A
How to test the change?
Added tests, and tested locally in the workspace.