dockerfile: remove gopath override #42
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
move the go install command so that it's called by the build user instead of root. running go install with root would lead to some folders in /go/pkg/ being owned by root and not writable by the build user, which eventually leads to permission errors when building the profiler, specifically to download new dependencies. also put /go in a volume which is persisted between consecutive runs, meaning docker-compose restart will reuse the go cache / go dependencies speeding up builds for local development.
nsavoire
approved these changes
Nov 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Move the go install command so that it's called by the build user instead of root.
Running go install with root would lead to some folders in /go/pkg/ being owned by root and not writable by the build user, which eventually leads to permission errors when building the profiler, specifically to download new dependencies.
Also put /go in a volume which is persisted between consecutive runs, meaning docker-compose restart will reuse the go cache / go dependencies speeding up builds for local development.
Motivation
Speed up local builds, fix permissions for
/godirectory.Additional Notes
N/A
How to test the change?
Tested locally with:
And verifying that all commands work, containers are started as expected, and during restart go dependencies are not fetched again.