Document that Mailer is available late

DataDog · Jun 19, 2024 · 0797c4e · 0797c4e
1 parent a305f6e
commit 0797c4e
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 2 deletions.
diff --git a/lib/datadog/tracing/contrib/action_mailer/events/deliver.rb b/lib/datadog/tracing/contrib/action_mailer/events/deliver.rb
@@ -39,7 +39,7 @@ def on_start(span, event, _id, payload)
             def on_finish(span, event, _id, payload)
               super
 
-              span.resource = payload[:mailer]
+              span.resource = payload[:mailer] # Mailer is not available at `on_start`
 
               span.set_tag(Ext::TAG_MAILER, payload[:mailer])
               span.set_tag(Ext::TAG_MSG_ID, payload[:message_id])

diff --git a/lib/datadog/tracing/contrib/action_mailer/events/process.rb b/lib/datadog/tracing/contrib/action_mailer/events/process.rb
@@ -33,7 +33,7 @@ def span_type
             def on_start(span, event, _id, payload)
               super
 
-              span.resource = payload[:mailer]
+              span.resource = payload[:mailer] # Mailer is not available at `on_start`
 
               span.set_tag(Ext::TAG_ACTION, payload[:action])
               span.set_tag(Ext::TAG_MAILER, payload[:mailer])