Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DEBUG-2334 Add Debugger component #3640

Merged
merged 4 commits into from
May 13, 2024
Merged

DEBUG-2334 Add Debugger component #3640

merged 4 commits into from
May 13, 2024

Conversation

p-datadog
Copy link
Contributor

This adds a component for Dynamic Instrumentation / Live Debugger using AppSec component as the model.

Included is a 'debugger' setting to turn the component on, and handling of DD_DYNAMIC_INSTRUMENTATION_ENABLED environment variable which is equivalent to the setting.

The component is not used by anything at this point and is/will remain off by default.

2.0 Upgrade Guide notes

How to test the change?
Unit tests only at this time.

@p
DEBUG-2334 Add Debugger component
427894e 
This adds a component for Dynamic Instrumentation / Live Debugger
using AppSec component as the model.

Included is a 'debugger' setting to turn the component on,
and handling of DD_DYNAMIC_INSTRUMENTATION_ENABLED environment
variable which is equivalent to the setting.
@p-datadog p-datadog requested a review from a team as a code owner May 10, 2024 18:15
@github-actions github-actions bot added the core Involves Datadog core libraries label May 10, 2024
@codecov-commenter
Copy link

Codecov Report

Attention: Patch coverage is 98.86364% with 1 lines in your changes are missing coverage. Please review.

Project coverage is 98.13%. Comparing base (a7dbf4c) to head (2071ae9).

Files Patch % Lines
lib/datadog/debugger.rb 88.88% 1 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##           master    #3640      +/-   ##
==========================================
- Coverage   98.13%   98.13%   -0.01%     
==========================================
  Files        1223     1230       +7     
  Lines       72139    72227      +88     
  Branches     3421     3425       +4     
==========================================
+ Hits        70795    70880      +85     
- Misses       1344     1347       +3

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

marcotc
marcotc approved these changes May 10, 2024
View reviewed changes
Copy link
Member

@marcotc marcotc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great, clean bootstrapping!

@p-datadog p-datadog merged commit 3d3cb43 into DataDog:master May 13, 2024
40 checks passed
@p-datadog p-datadog deleted the debugger-component branch May 13, 2024 16:25
p-datadog pushed a commit to p-datadog/dd-trace-rb that referenced this pull request May 13, 2024
@p
Merge branch 'master' into base
64d5ccf 
* master: (50 commits)
  DEBUG-2334 Add Debugger component (DataDog#3640)
  Delay ENV propagation resolved with GEM_PATH
  Revert "Change bundle add mechanism"
  Use outdated msgpack
  Shortcircuit when failure
  Change bundle add mechanism
  Renamed to CachingResolver
  Minor: Empty commit to re-trigger CI
  Assert that correct signal name is reported
  Assert that no crashtracker is running before each test
  Minor: Add explanation for why we're skipping crash tracker with custom transports
  Make rubocop happy
  Fix `upload_timeout_seconds` being a float by default
  Remove temporary libdatadog monkey patch
  Use `profiling.upload.timeout_seconds` for crashtracker timeout
  Setup `ld_library_path` argument for crashtracker
  Update Ruby crashtracker to libdatadog v9 API
  Revert "Update gemfiles with libdatadog 7 -> 8 upgrade"
  Revert "[NO-TICKET] Upgrade to libdatadog 8"
  Minor: Fix length of guide comment for breaking lines in message
  ...
p-datadog pushed a commit to p-datadog/dd-trace-rb that referenced this pull request May 13, 2024
@p
Merge branch 'base' into base-merge
b174ba9 
* base: (50 commits)
  DEBUG-2334 Add Debugger component (DataDog#3640)
  Delay ENV propagation resolved with GEM_PATH
  Revert "Change bundle add mechanism"
  Use outdated msgpack
  Shortcircuit when failure
  Change bundle add mechanism
  Renamed to CachingResolver
  Minor: Empty commit to re-trigger CI
  Assert that correct signal name is reported
  Assert that no crashtracker is running before each test
  Minor: Add explanation for why we're skipping crash tracker with custom transports
  Make rubocop happy
  Fix `upload_timeout_seconds` being a float by default
  Remove temporary libdatadog monkey patch
  Use `profiling.upload.timeout_seconds` for crashtracker timeout
  Setup `ld_library_path` argument for crashtracker
  Update Ruby crashtracker to libdatadog v9 API
  Revert "Update gemfiles with libdatadog 7 -> 8 upgrade"
  Revert "[NO-TICKET] Upgrade to libdatadog 8"
  Minor: Fix length of guide comment for breaking lines in message
  ...
marcotc added a commit that referenced this pull request May 23, 2024
@marcotc
Revert "DEBUG-2334 Add Debugger component (#3640)"
554b6d9 
This reverts commit 3d3cb43.
@marcotc marcotc mentioned this pull request May 23, 2024
Merged
p-datadog pushed a commit to p-datadog/dd-trace-rb that referenced this pull request Jun 4, 2024
@p
Merge branch 'master' into hanami-ci
3713c4b 
* master: (22 commits)
  Remove experimental warning from OpenTelemetry.md
  Remove latest tag on docker images
  add installer system tests
  Extract trace id format helper method (DataDog#3670)
  Remaps http status code tag for otel span for trace metrics (DataDog#3664)
  Update .github/labeler.yml
  Use 3.20
  rb -> ruby
  Add a note about `use` vs `instrument`
  GitHub: Update labeller bot with new products
  Update lockfiles for release 2.0.0.rc1
  Bump version 2.0.0.beta2 to 2.0.0.rc1
  Add 2.0.0.rc1 to CHANGELOG.md
  chore(lib-injection): update base image to alpine 3.18.6
  Apply suggestions from code review
  Revert "DEBUG-2334 Add Debugger component (DataDog#3640)"
  Implement `latest_major` and `lastest_minor` tag for docker init container (DataDog#3643)
  Build oci package
  Update `rexml`  (DataDog#3656)
  Remove bundler cache in for `setup-ruby` step and pin bundler and rubygem version
  ...
p-datadog pushed a commit to p-datadog/dd-trace-rb that referenced this pull request Jun 6, 2024
@p
Revert "Revert "DEBUG-2334 Add Debugger component (DataDog#3640)""
848f46c 
This reverts commit 554b6d9.
p-datadog pushed a commit to p-datadog/dd-trace-rb that referenced this pull request Jun 6, 2024
@p
Merge branch 'master-merge-to-di' into base-merge
dbc0f4d 
* master-merge-to-di: (37 commits)
  Revert "Revert "DEBUG-2334 Add Debugger component (DataDog#3640)""
  Update lockfiles for release 2.0.0
  Bump version 2.0.0.rc1 to 2.0.0
  Add 2.0.0 to CHANGELOG.md
  Add missing Apache 2.0 license from gemspec
  Use ffi 1.16.3
  Add platform
  Output gem version
  Output debug logs
  Fix spec to exclude .vscode directory
  Fix docker run command
  Add vscode settings for dockerfile file associations
  Update gem version
  Update gemfiles/*
  Update `ffi` in Gemfile
  Remove experimental warning from OpenTelemetry.md
  Remove latest tag on docker images
  add installer system tests
  Extract trace id format helper method (DataDog#3670)
  Remaps http status code tag for otel span for trace metrics (DataDog#3664)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@marcotc marcotc marcotc approved these changes

Assignees
No one assigned
Labels
core Involves Datadog core libraries
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@p-datadog @codecov-commenter @marcotc @p