Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Document environment variables to disable instrumentation #3728

Merged
merged 4 commits into from
Jun 25, 2024
Merged

Conversation

marcotc
Copy link
Member

@marcotc marcotc commented Jun 20, 2024

This PR documents all "DD_TRACE_#{integration}_ENABLED" environment variables.

Today, these exists but are undocumented.

@marcotc marcotc added the docs Involves documentation label Jun 20, 2024
@marcotc marcotc requested a review from a team as a code owner June 20, 2024 02:41
@marcotc marcotc self-assigned this Jun 20, 2024
@marcotc
Copy link
Member Author

marcotc commented Jun 20, 2024

It is much easier to review this PR using the "Display the rich diff" view:
Screenshot 2024-06-19 at 7 41 58 PM

Copy link
Contributor

@TonyCTHsu TonyCTHsu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Nitpick: Can we make the enabled as the first row of each table?

docs/GettingStarted.md Outdated Show resolved Hide resolved
docs/GettingStarted.md Outdated Show resolved Hide resolved
@hestonhoffman hestonhoffman added the editorial review Waiting for a review from the docs team label Jun 21, 2024
@marcotc marcotc enabled auto-merge June 21, 2024 19:03
Copy link
Contributor

@brett0000FF brett0000FF left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM from Doc's side. 🚀

@marcotc marcotc merged commit 8ce5daf into master Jun 25, 2024
163 of 165 checks passed
@marcotc marcotc deleted the disable-env branch June 25, 2024 11:37
@github-actions github-actions bot added this to the 2.2.0 milestone Jun 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs Involves documentation editorial review Waiting for a review from the docs team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants