Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[NO-TICKET] Upgrade to libdatadog 14.0 #4065

Merged
merged 4 commits into from
Nov 6, 2024
Merged

Commits on Nov 5, 2024

  1. [NO-TICKET] Upgrade to libdatadog 14.0

    **What does this PR do?**
    
    This PR upgrades the libdatadog dependency to the latest 14.0 release.
    
    It also updates our API usage to match some 13.1 -> 14.0 changes.
    
    **Motivation:**
    
    The libdatadog 14.0 release includes a number of improvements to
    the crashtracking implementation, and we want to pick them up.
    
    **Additional Notes:**
    
    As a first pass, I've disabled the creation and use of the alt
    stack, to match our existing setup.
    
    I did not yet experiment with `use_alt_stack = true`.
    
    **How to test the change?**
    
    Existing test coverage should be enough to cover our libdatadog
    API usage.
    ivoanjo committed Nov 5, 2024
    Configuration menu
    Copy the full SHA
    947a583 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    930fc88 View commit details
    Browse the repository at this point in the history

Commits on Nov 6, 2024

  1. Configuration menu
    Copy the full SHA
    6c6a7ae View commit details
    Browse the repository at this point in the history
  2. Enable use_alt_stack setting for crashtracker

    I spent some time looking into `use_alt_stack` setting and I think
    there's a bug in libdatadog and that setting doesn't seem to be doing
    anything at this point.
    
    Since the Ruby VM itself sets an altstack, this leaves us:
    
    * In libdatadog 13.1, the crashtracker code always used the altstack
      (e.g. equivalent of `use_alt_stack` was hardcoded to `true`)
      => in libdatadog 13.1 we used the Ruby altstack
    * In libdatadog 14.0, the crashtracker code chooses to use the altstack
      based on the value of `create_alt_stack` => libdatadog 14.0 we can't
      use the Ruby altstack
    
    In preparation for `use_alt_stack` to get fixed in a future libdatadog
    release, I'm changing it to true although, right now it's a no-op.
    
    This means that in a future libdatadog release, we'll be back to where
    we were in libdatadog 13.1: the crashtracker DOES NOT create its
    own altstack, BUT WILL USE the existing Ruby altstack.
    ivoanjo committed Nov 6, 2024
    Configuration menu
    Copy the full SHA
    ddbbbcb View commit details
    Browse the repository at this point in the history