-
Notifications
You must be signed in to change notification settings - Fork 375
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update bundler and uri #4124
Merged
Merged
Update bundler and uri #4124
+340
−1,151
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #4124 +/- ##
==========================================
+ Coverage 97.77% 97.78% +0.01%
==========================================
Files 1350 1350
Lines 81262 81263 +1
Branches 4108 4108
==========================================
+ Hits 79452 79463 +11
+ Misses 1810 1800 -10 ☔ View full report in Codecov by Sentry. |
anmarchenko
approved these changes
Nov 18, 2024
This is strange to me:
In master |
p-datadog
approved these changes
Nov 18, 2024
Merging this and address benchmark later. Because branch conflict is hard |
p-datadog
added
the
dev/internal
Other internal work that does not need to be included in the changelog
label
Nov 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
dev/internal
Other internal work that does not need to be included in the changelog
dev/testing
Involves testing processes (e.g. RSpec)
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation:
uri
gem is no longer required.uri
and a fix forpysch
https://github.com/rubygems/rubygems/blob/master/bundler/CHANGELOG.md#2522-october-16-2024
What does this PR do?
uri
gem