Fix execution spec with cucumber on ruby 3.4 #4128
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
p-datadog
force-pushed
the
cucumber-ruby-3.4
branch
from
32851b1
to
5cd0fad
Compare
Cucumber is broken on ruby 3.4 currently, requires the fix in cucumber/cucumber-ruby#1757 (not released yet). Use their master from git on ruby 3.4 and unpend the test.
p-datadog
force-pushed
the
cucumber-ruby-3.4
branch
from
5cd0fad
to
5e06e38
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #4128 +/- ##
==========================================
+ Coverage 97.77% 97.79% +0.01%
==========================================
Files 1350 1350
Lines 81278 81276 -2
Branches 4108 4107 -1
==========================================
+ Hits 79471 79481 +10
+ Misses 1807 1795 -12 ☔ View full report in Codecov by Sentry. 🚨 Try these New Features:
|
p-datadog
added
the
dev/internal
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Cucumber is broken on ruby 3.4 currently, requires the fix in cucumber/cucumber-ruby#1757 (not released yet).
Use their master from git on ruby 3.4 and unpend the test.
Motivation:
Investigating intermittent failure in that test on the other Ruby versions.
Change log entry
None
Additional Notes:
How to test the change?
Existing test is unpended.