-
Notifications
You must be signed in to change notification settings - Fork 375
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Lower glibc requirements for SSI #4137
Conversation
BenchmarksBenchmark execution time: 2024-11-21 09:45:31 Comparing candidate commit e958e16 in PR branch Found 0 performance improvements and 1 performance regressions! Performance is the same for 30 metrics, 2 unstable metrics. scenario:profiler - stack collector
|
65de52e
to
e958e16
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There are some followups:
- Update
lib-injection/README.md
about the Ruby versions 3.3 (Probably not 3.4 since it is has not been official release) - Update vaccine to validate 3.3 runtime
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #4137 +/- ##
==========================================
- Coverage 97.78% 97.77% -0.02%
==========================================
Files 1350 1350
Lines 81322 81322
Branches 4107 4107
==========================================
- Hits 79522 79512 -10
- Misses 1800 1810 +10 ☔ View full report in Codecov by Sentry. 🚨 Try these New Features:
|
What does this PR do?
Motivation:
Change log entry
Lower SSI GLIBC requirements down to 2.17
Additional Notes:
Unsure if GitLab can pull from https://ghcr.io/datadog/images-rb, an intermediate mirroring in https://ghcr.io/datadog/images might be needed.
How to test the change?
GitLab CI should pass.