Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Lower glibc requirements for SSI #4137

Merged
merged 2 commits into from
Nov 21, 2024
Merged

Conversation

lloeki
Copy link
Contributor

@lloeki lloeki commented Nov 21, 2024

What does this PR do?

Motivation:

Change log entry

Lower SSI GLIBC requirements down to 2.17

Additional Notes:

Unsure if GitLab can pull from https://ghcr.io/datadog/images-rb, an intermediate mirroring in https://ghcr.io/datadog/images might be needed.

How to test the change?

GitLab CI should pass.

@lloeki lloeki requested a review from a team as a code owner November 21, 2024 08:21
@lloeki lloeki requested a review from a team as a code owner November 21, 2024 08:35
@github-actions github-actions bot added the single-step Single Step APM Instrumentation label Nov 21, 2024
@pr-commenter
Copy link

pr-commenter bot commented Nov 21, 2024

Benchmarks

Benchmark execution time: 2024-11-21 09:45:31

Comparing candidate commit e958e16 in PR branch lloeki/lower-glibc-requirement with baseline commit 2dd2fa3 in branch master.

Found 0 performance improvements and 1 performance regressions! Performance is the same for 30 metrics, 2 unstable metrics.

scenario:profiler - stack collector

  • 🟥 throughput [-167.152op/s; -165.348op/s] or [-5.687%; -5.625%]

@lloeki lloeki force-pushed the lloeki/lower-glibc-requirement branch from 65de52e to e958e16 Compare November 21, 2024 08:50
Copy link
Contributor

@TonyCTHsu TonyCTHsu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are some followups:

  1. Update lib-injection/README.md about the Ruby versions 3.3 (Probably not 3.4 since it is has not been official release)
  2. Update vaccine to validate 3.3 runtime

@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 97.77%. Comparing base (b0b8015) to head (e958e16).
Report is 1 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #4137      +/-   ##
==========================================
- Coverage   97.78%   97.77%   -0.02%     
==========================================
  Files        1350     1350              
  Lines       81322    81322              
  Branches     4107     4107              
==========================================
- Hits        79522    79512      -10     
- Misses       1800     1810      +10     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.


🚨 Try these New Features:

@lloeki lloeki merged commit 0dec342 into master Nov 21, 2024
287 checks passed
@lloeki lloeki deleted the lloeki/lower-glibc-requirement branch November 21, 2024 11:00
@github-actions github-actions bot added this to the 2.8.0 milestone Nov 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
single-step Single Step APM Instrumentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants