DEBUG-2334 respect maxFieldCount in probe specification #4142
+49
−18
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Maximum capture attribute count can be specified in the probe, implement support for it in DI.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #4142 +/- ##
=======================================
Coverage 97.77% 97.78%
=======================================
Files 1350 1350
Lines 81322 81328 +6
Branches 4107 4107
=======================================
+ Hits 79515 79525 +10
+ Misses 1807 1803 -4 ☔ View full report in Codecov by Sentry. 🚨 Try these New Features:
|
marcotc
approved these changes
Nov 21, 2024
p-datadog
pushed a commit
that referenced
this pull request
Nov 21, 2024
* psych-fix: Attempt to fix psych test flakiness DEBUG-2334 respect maxFieldCount in probe specification (#4142) Revert "Run the cucumber test in unbundled environment" (#4143) Update guard rails and doc (Excluding 3.4 installation) Lower declared requirements Use CentOS 7 images for SSI DEBUG-2334 require ostruct for OpenStruct dependency (#4135) DEBUG-2334 Set duration to 0 for DI line probes (#4134)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Maximum capture attribute count can be specified in the probe,
This PR implements support for it in DI.
Motivation:
System tests exposed the fact that Ruby DI did not read & propagate max field count from probe specification to the serializer.
Change log entry
None
Additional Notes:
How to test the change?
Tested by DataDog/system-tests#3516 + unit tests in this PR.