Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "Run the cucumber test in unbundled environment" #4143

Merged
merged 1 commit into from
Nov 21, 2024

Conversation

p-datadog
Copy link
Contributor

Reverts #4130

I missed that there was already a request to run the command in unbundled environment two lines below, thus the original PR did not add any value.

@p-datadog p-datadog requested a review from a team as a code owner November 21, 2024 18:44
@github-actions github-actions bot added the dev/testing Involves testing processes (e.g. RSpec) label Nov 21, 2024
@pr-commenter
Copy link

pr-commenter bot commented Nov 21, 2024

Benchmarks

Benchmark execution time: 2024-11-21 19:24:42

Comparing candidate commit 3aa9c0e in PR branch revert-4130-fix-cucumber-spec with baseline commit 7a345da in branch master.

Found 3 performance improvements and 0 performance regressions! Performance is the same for 28 metrics, 2 unstable metrics.

scenario:line instrumentation - targeted

  • 🟩 throughput [+17883.832op/s; +18699.691op/s] or [+9.534%; +9.969%]

scenario:line instrumentation - untargeted

  • 🟩 throughput [+5261.544op/s; +5524.788op/s] or [+5.138%; +5.395%]

scenario:method instrumentation

  • 🟩 throughput [+18155.108op/s; +19055.792op/s] or [+8.705%; +9.137%]

@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 97.79%. Comparing base (7a345da) to head (3aa9c0e).

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #4143      +/-   ##
==========================================
+ Coverage   97.77%   97.79%   +0.01%     
==========================================
  Files        1350     1350              
  Lines       81322    81322              
  Branches     4107     4107              
==========================================
+ Hits        79515    79525      +10     
+ Misses       1807     1797      -10     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.


🚨 Try these New Features:

@p-datadog p-datadog merged commit be5f5ac into master Nov 21, 2024
289 checks passed
@p-datadog p-datadog deleted the revert-4130-fix-cucumber-spec branch November 21, 2024 21:26
@github-actions github-actions bot added this to the 2.8.0 milestone Nov 21, 2024
p-datadog pushed a commit that referenced this pull request Nov 21, 2024
* psych-fix:
  Attempt to fix psych test flakiness
  DEBUG-2334 respect maxFieldCount in probe specification (#4142)
  Revert "Run the cucumber test in unbundled environment" (#4143)
  Update guard rails and doc (Excluding 3.4 installation)
  Lower declared requirements
  Use CentOS 7 images for SSI
  DEBUG-2334 require ostruct for OpenStruct dependency (#4135)
  DEBUG-2334 Set duration to 0 for DI line probes (#4134)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dev/testing Involves testing processes (e.g. RSpec)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants