DEBUG-2334 do not try to install pending probes on eval'd code #4166
+85
−10
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Fixes incorrect placement of the call to install pending probes in script_compiled trace point handler. The call should only be made if there is a path corresponding to the code having been compiled (i.e., code was required or loaded but not evaled). Previously the call was outside of the conditional checking if path is present and would be made also for eval'd code, subsequently failing in path suffix matching.
Motivation:
The failure manifested in my local testing with "propagate all exceptions" flag set which I normally have on.
Change log entry
None
Additional Notes:
The existing exception boundaries prevent the issue being repaired in this PR from having customer impact - it would only generate noise in the log. The exception boundary at trace point execution means the trace point execution wouldn't do anything, but it should do nothing for eval'd code.
How to test the change?
Unit tests are included