Skip to content

Commit

Permalink
Merge pull request #128 from DataDog/quentin/1.27.0
Browse files Browse the repository at this point in the history
Prepare 1.27.0 release
  • Loading branch information
degemer authored May 1, 2017
2 parents 9492b93 + 9896577 commit f5bd28e
Show file tree
Hide file tree
Showing 4 changed files with 11 additions and 6 deletions.
7 changes: 6 additions & 1 deletion CHANGELOG.md
Original file line number Diff line number Diff line change
@@ -1,6 +1,10 @@
Changes
=======

# 1.27.0 / UNRELEASED

* [FEATURE] Add monitor validation endpoint. See [#127][]

# 1.26.0 / 2017-04-10

* [IMPROVEMENT] Allow additional options to be passed to monitor API calls. See [#125][] (thanks [@jimmyngo][])
Expand Down Expand Up @@ -178,6 +182,7 @@ This is the last release compatible with Ruby 1.8. ([EOL 2013-06-30](https://www
[#115]: https://github.com/DataDog/dogapi-rb/issues/115
[#120]: https://github.com/DataDog/dogapi-rb/issues/120
[#125]: https://github.com/DataDog/dogapi-rb/issues/125
[#127]: https://github.com/DataDog/dogapi-rb/issues/127
[@ArjenSchwarz]: https://github.com/ArjenSchwarz
[@Kaixiang]: https://github.com/Kaixiang
[@ansel1]: https://github.com/ansel1
Expand All @@ -192,4 +197,4 @@ This is the last release compatible with Ruby 1.8. ([EOL 2013-06-30](https://www
[@rmoriz]: https://github.com/rmoriz
[@treeder]: https://github.com/treeder
[@winebarrel]: https://github.com/winebarrel
[@yyuu]: https://github.com/yyuu
[@yyuu]: https://github.com/yyuu
4 changes: 2 additions & 2 deletions lib/dogapi/facade.rb
Original file line number Diff line number Diff line change
Expand Up @@ -408,8 +408,8 @@ def get_all_monitors(options= {})
@monitor_svc.get_all_monitors(options)
end

def monitor_validate(type, query, options= {})
@monitor_svc.monitor_validate(type, query, options)
def validate_monitor(type, query, options= {})
@monitor_svc.validate_monitor(type, query, options)
end

def mute_monitors()
Expand Down
2 changes: 1 addition & 1 deletion lib/dogapi/v1/monitor.rb
Original file line number Diff line number Diff line change
Expand Up @@ -53,7 +53,7 @@ def get_all_monitors(options = {})
request(Net::HTTP::Get, "/api/#{API_VERSION}/monitor", extra_params, nil, false)
end

def monitor_validate(type, query, options = {})
def validate_monitor(type, query, options = {})
body = {
'type' => type,
'query' => query,
Expand Down
4 changes: 2 additions & 2 deletions spec/integration/monitor_spec.rb
Original file line number Diff line number Diff line change
Expand Up @@ -40,8 +40,8 @@

describe '#validate_monitor' do
it_behaves_like 'an api method with options',
:monitor, [MONITOR_TYPE, MONITOR_QUERY],
:post, '/monitor', 'type' => MONITOR_TYPE, 'query' => MONITOR_QUERY
:validate_monitor, [MONITOR_TYPE, MONITOR_QUERY],
:post, '/monitor/validate', 'type' => MONITOR_TYPE, 'query' => MONITOR_QUERY
end

describe '#mute_monitors' do
Expand Down

0 comments on commit f5bd28e

Please sign in to comment.