Add "prev" field in Link attribute #60
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chrismclennon
requested review from
a team,
turettn and
hgu7
and removed request for
a team
| @@ -84,6 +85,7 @@ type Link struct { | |||
| Last string `json:"last,omitempty"` | |||
| Next string `json:"next,omitempty"` | |||
| Previous string `json:"previous,omitempty"` | |||
There was a problem hiding this comment.
minor: I'd recommend placing the comment as close to the field as possible, I believe it will be more readable this way.
Suggested change
| Previous string `json:"previous,omitempty"` | |
| // Previous is deprecated and kept for backwards compatibility. Instead, use the Prev field. | |
| Previous string `json:"previous,omitempty"` |
or perhaps,
Suggested change
| Previous string `json:"previous,omitempty"` | |
| // DEPRECATED: Use the Prev field. | |
| Previous string `json:"previous,omitempty"` |
There was a problem hiding this comment.
Moved the comment !
chrismclennon
approved these changes
Dec 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In JSON API specification, there are 4 fields that are mandatory :
first: the first page of datalast: the last page of dataprev: the previous page of datanext: the next page of dataThere is currently a
previousfield but noprevfield. This PR addprevfield and keepspreviousfield for backwards compatibility