Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Profiling/Build] Add crashtracking feature for windows (event it's not ready yet) #613

Merged
merged 2 commits into from
Sep 12, 2024
Merged

[Profiling/Build] Add crashtracking feature for windows (event it's not ready yet) #613

merged 2 commits into from
Sep 12, 2024

Conversation

gleocadie
Copy link
Contributor

@gleocadie gleocadie commented Sep 6, 2024 •
edited
Loading

What does this PR do?

Since #551, crashtracker has its own header crashtracker.h. This header is not part of the nuget package and prevent compilation on windows.

Motivation

Make sure we can compile in Visual Studio.

Additional Notes

Waiting for #611

Anything else we should know when reviewing?

How to test the change?

Downloaded the nuget package (from the gitlab job) and checked that :

  • crashtracker.h is present
  • ddog_crasht_demangle symbol is present

@github-actions github-actions bot added profiling Relates to the profiling* modules. ci-build labels Sep 6, 2024
@codecov-commenter
Copy link

codecov-commenter commented Sep 6, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 73.13%. Comparing base (9705ec2) to head (302f257).
Report is 3 commits behind head on main.

Additional details and impacted files 
@@           Coverage Diff           @@
##             main     #613   +/-   ##
=======================================
  Coverage   73.13%   73.13%           
=======================================
  Files         252      252           
  Lines       35959    35959           
=======================================
  Hits        26300    26300           
  Misses       9659     9659
Components Coverage Δ
crashtracker 20.53% <ø> (ø)
datadog-alloc 98.73% <ø> (ø)
data-pipeline 90.12% <ø> (ø)
data-pipeline-ffi 0.00% <ø> (ø)
ddcommon 83.08% <ø> (ø)
ddcommon-ffi 69.52% <ø> (ø)
ddtelemetry 59.10% <ø> (ø)
ipc 83.63% <ø> (ø)
profiling 84.26% <ø> (ø)
profiling-ffi 77.42% <ø> (ø)
serverless 0.00% <ø> (ø)
sidecar 40.12% <ø> (ø)
sidecar-ffi 0.00% <ø> (ø)
spawn-worker 50.36% <ø> (ø)
tinybytes 91.66% <ø> (ø)
trace-mini-agent 70.88% <ø> (ø)
trace-normalization 98.25% <ø> (ø)
trace-obfuscation 95.73% <ø> (ø)
trace-protobuf 77.67% <ø> (ø)
trace-utils 92.86% <ø> (ø)

@pr-commenter
Copy link

pr-commenter bot commented Sep 6, 2024 •
edited
Loading

Benchmarks

Comparison

Benchmark execution time: 2024-09-11 12:01:04

Comparing candidate commit 302f257 in PR branch gleocadie/add-crashtracking-feature-for-windows with baseline commit 54ed2cf in branch main.

Found 2 performance improvements and 0 performance regressions! Performance is the same for 49 metrics, 2 unstable metrics.

scenario:benching string interning on wordpress profile

  • 🟩 execution_time [-5.011µs; -4.498µs] or [-3.369%; -3.025%]

scenario:concentrator/add_spans_to_concentrator

  • 🟩 execution_time [-393.779µs; -379.786µs] or [-4.163%; -4.015%]

Candidate

Candidate benchmark details

Group 1

cpu_model git_commit_sha git_commit_date git_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz 302f257 1726055434 gleocadie/add-crashtracking-feature-for-windows
scenario metric min mean ± sd median ± mad p75 p95 p99 max peak_to_median_ratio skewness kurtosis cv sem runs sample_size
normalization/normalize_trace/test_trace execution_time 291.291ns 301.216ns ± 14.531ns 295.424ns ± 2.650ns 300.953ns 337.455ns 350.605ns 350.767ns 18.73% 2.222 4.011 4.81% 1.027ns 1 200
scenario metric 95% CI mean Shapiro-Wilk pvalue Ljung-Box pvalue (lag=1) Dip test pvalue
normalization/normalize_trace/test_trace execution_time [299.202ns; 303.230ns] or [-0.669%; +0.669%] None None None

Group 2

cpu_model git_commit_sha git_commit_date git_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz 302f257 1726055434 gleocadie/add-crashtracking-feature-for-windows
scenario metric min mean ± sd median ± mad p75 p95 p99 max peak_to_median_ratio skewness kurtosis cv sem runs sample_size
sql/obfuscate_sql_string execution_time 72.558µs 72.817µs ± 0.211µs 72.752µs ± 0.072µs 72.885µs 73.134µs 73.420µs 74.511µs 2.42% 3.315 20.289 0.29% 0.015µs 1 200
scenario metric 95% CI mean Shapiro-Wilk pvalue Ljung-Box pvalue (lag=1) Dip test pvalue
sql/obfuscate_sql_string execution_time [72.787µs; 72.846µs] or [-0.040%; +0.040%] None None None

Group 3

cpu_model git_commit_sha git_commit_date git_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz 302f257 1726055434 gleocadie/add-crashtracking-feature-for-windows
scenario metric min mean ± sd median ± mad p75 p95 p99 max peak_to_median_ratio skewness kurtosis cv sem runs sample_size
benching string interning on wordpress profile execution_time 142.843µs 143.965µs ± 0.463µs 143.912µs ± 0.205µs 144.121µs 144.687µs 145.161µs 147.580µs 2.55% 2.831 18.792 0.32% 0.033µs 1 200
scenario metric 95% CI mean Shapiro-Wilk pvalue Ljung-Box pvalue (lag=1) Dip test pvalue
benching string interning on wordpress profile execution_time [143.901µs; 144.030µs] or [-0.045%; +0.045%] None None None

Group 4

cpu_model git_commit_sha git_commit_date git_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz 302f257 1726055434 gleocadie/add-crashtracking-feature-for-windows
scenario metric min mean ± sd median ± mad p75 p95 p99 max peak_to_median_ratio skewness kurtosis cv sem runs sample_size
normalization/normalize_service/normalize_service/A0000000000000000000000000000000000000000000000000... execution_time 578.575µs 579.679µs ± 0.350µs 579.677µs ± 0.203µs 579.894µs 580.255µs 580.505µs 580.937µs 0.22% -0.149 1.182 0.06% 0.025µs 1 200
normalization/normalize_service/normalize_service/A0000000000000000000000000000000000000000000000000... throughput 1721358.531op/s 1725094.107op/s ± 1040.976op/s 1725098.168op/s ± 603.838op/s 1725621.585op/s 1726821.147op/s 1727887.834op/s 1728383.086op/s 0.19% 0.155 1.182 0.06% 73.608op/s 1 200
normalization/normalize_service/normalize_service/Data🐨dog🐶 繋がっ⛰てて execution_time 464.127µs 464.805µs ± 0.284µs 464.785µs ± 0.167µs 464.988µs 465.239µs 465.466µs 465.727µs 0.20% 0.292 0.415 0.06% 0.020µs 1 200
normalization/normalize_service/normalize_service/Data🐨dog🐶 繋がっ⛰てて throughput 2147182.828op/s 2151441.862op/s ± 1313.167op/s 2151530.358op/s ± 772.077op/s 2152262.002op/s 2153645.588op/s 2154353.669op/s 2154584.400op/s 0.14% -0.287 0.411 0.06% 92.855op/s 1 200
normalization/normalize_service/normalize_service/Test Conversion 0f Weird !@#$%^&**() Characters execution_time 184.016µs 184.351µs ± 0.161µs 184.337µs ± 0.112µs 184.464µs 184.618µs 184.708µs 184.772µs 0.24% 0.210 -0.560 0.09% 0.011µs 1 200
normalization/normalize_service/normalize_service/Test Conversion 0f Weird !@#$%^&**() Characters throughput 5412073.279op/s 5424453.568op/s ± 4746.514op/s 5424836.117op/s ± 3306.299op/s 5427808.084op/s 5431423.032op/s 5434222.597op/s 5434299.256op/s 0.17% -0.206 -0.562 0.09% 335.629op/s 1 200
normalization/normalize_service/normalize_service/[empty string] execution_time 46.402µs 46.636µs ± 0.092µs 46.630µs ± 0.054µs 46.687µs 46.773µs 46.817µs 47.255µs 1.34% 1.461 9.257 0.20% 0.006µs 1 200
normalization/normalize_service/normalize_service/[empty string] throughput 21161953.329op/s 21442683.719op/s ± 41966.751op/s 21445589.398op/s ± 24707.349op/s 21465457.445op/s 21500003.400op/s 21520426.997op/s 21550785.343op/s 0.49% -1.408 8.865 0.20% 2967.497op/s 1 200
normalization/normalize_service/normalize_service/test_ASCII execution_time 44.236µs 45.050µs ± 0.291µs 45.039µs ± 0.260µs 45.335µs 45.418µs 45.466µs 45.613µs 1.28% -0.437 -0.494 0.64% 0.021µs 1 200
normalization/normalize_service/normalize_service/test_ASCII throughput 21923656.231op/s 22198267.812op/s ± 143820.571op/s 22203202.561op/s ± 128353.457op/s 22296693.526op/s 22438890.113op/s 22568441.922op/s 22606120.102op/s 1.81% 0.462 -0.445 0.65% 10169.650op/s 1 200
scenario metric 95% CI mean Shapiro-Wilk pvalue Ljung-Box pvalue (lag=1) Dip test pvalue
normalization/normalize_service/normalize_service/A0000000000000000000000000000000000000000000000000... execution_time [579.630µs; 579.727µs] or [-0.008%; +0.008%] None None None
normalization/normalize_service/normalize_service/A0000000000000000000000000000000000000000000000000... throughput [1724949.838op/s; 1725238.376op/s] or [-0.008%; +0.008%] None None None
normalization/normalize_service/normalize_service/Data🐨dog🐶 繋がっ⛰てて execution_time [464.765µs; 464.844µs] or [-0.008%; +0.008%] None None None
normalization/normalize_service/normalize_service/Data🐨dog🐶 繋がっ⛰てて throughput [2151259.870op/s; 2151623.854op/s] or [-0.008%; +0.008%] None None None
normalization/normalize_service/normalize_service/Test Conversion 0f Weird !@#$%^&**() Characters execution_time [184.328µs; 184.373µs] or [-0.012%; +0.012%] None None None
normalization/normalize_service/normalize_service/Test Conversion 0f Weird !@#$%^&**() Characters throughput [5423795.747op/s; 5425111.390op/s] or [-0.012%; +0.012%] None None None
normalization/normalize_service/normalize_service/[empty string] execution_time [46.623µs; 46.649µs] or [-0.027%; +0.027%] None None None
normalization/normalize_service/normalize_service/[empty string] throughput [21436867.531op/s; 21448499.907op/s] or [-0.027%; +0.027%] None None None
normalization/normalize_service/normalize_service/test_ASCII execution_time [45.010µs; 45.091µs] or [-0.090%; +0.090%] None None None
normalization/normalize_service/normalize_service/test_ASCII throughput [22178335.664op/s; 22218199.960op/s] or [-0.090%; +0.090%] None None None

Group 5

cpu_model git_commit_sha git_commit_date git_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz 302f257 1726055434 gleocadie/add-crashtracking-feature-for-windows
scenario metric min mean ± sd median ± mad p75 p95 p99 max peak_to_median_ratio skewness kurtosis cv sem runs sample_size
concentrator/add_spans_to_concentrator execution_time 9.023ms 9.072ms ± 0.049ms 9.057ms ± 0.011ms 9.075ms 9.176ms 9.257ms 9.327ms 2.98% 2.933 9.567 0.54% 0.003ms 1 200
scenario metric 95% CI mean Shapiro-Wilk pvalue Ljung-Box pvalue (lag=1) Dip test pvalue
concentrator/add_spans_to_concentrator execution_time [9.066ms; 9.079ms] or [-0.074%; +0.074%] None None None

Group 6

cpu_model git_commit_sha git_commit_date git_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz 302f257 1726055434 gleocadie/add-crashtracking-feature-for-windows
scenario metric min mean ± sd median ± mad p75 p95 p99 max peak_to_median_ratio skewness kurtosis cv sem runs sample_size
benching deserializing traces from msgpack to their internal representation execution_time 1.243µs 1.339µs ± 0.053µs 1.349µs ± 0.036µs 1.379µs 1.427µs 1.431µs 1.455µs 7.90% -0.094 -1.068 3.92% 0.004µs 1 200
scenario metric 95% CI mean Shapiro-Wilk pvalue Ljung-Box pvalue (lag=1) Dip test pvalue
benching deserializing traces from msgpack to their internal representation execution_time [1.332µs; 1.346µs] or [-0.544%; +0.544%] None None None

Group 7

cpu_model git_commit_sha git_commit_date git_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz 302f257 1726055434 gleocadie/add-crashtracking-feature-for-windows
scenario metric min mean ± sd median ± mad p75 p95 p99 max peak_to_median_ratio skewness kurtosis cv sem runs sample_size
credit_card/is_card_number/ execution_time 1.211µs 1.212µs ± 0.001µs 1.212µs ± 0.000µs 1.213µs 1.213µs 1.214µs 1.219µs 0.56% 5.386 52.864 0.05% 0.000µs 1 200
credit_card/is_card_number/ throughput 820245960.473op/s 824805941.628op/s ± 447291.546op/s 824853767.862op/s ± 211362.769op/s 825022764.486op/s 825376453.112op/s 825460079.359op/s 825484461.946op/s 0.08% -5.344 52.305 0.05% 31628.289op/s 1 200
credit_card/is_card_number/ 3782-8224-6310-005 execution_time 107.999µs 109.132µs ± 0.659µs 109.021µs ± 0.402µs 109.475µs 110.507µs 111.113µs 111.422µs 2.20% 1.001 1.018 0.60% 0.047µs 1 200
credit_card/is_card_number/ 3782-8224-6310-005 throughput 8974866.374op/s 9163577.041op/s ± 54992.433op/s 9172541.543op/s ± 33821.582op/s 9202195.646op/s 9233902.346op/s 9250471.484op/s 9259358.041op/s 0.95% -0.965 0.924 0.60% 3888.552op/s 1 200
credit_card/is_card_number/ 378282246310005 execution_time 102.143µs 102.914µs ± 0.693µs 102.673µs ± 0.232µs 103.105µs 104.321µs 105.196µs 106.663µs 3.89% 2.107 5.520 0.67% 0.049µs 1 200
credit_card/is_card_number/ 378282246310005 throughput 9375337.524op/s 9717283.552op/s ± 64575.747op/s 9739675.858op/s ± 22015.340op/s 9758090.223op/s 9776398.283op/s 9784995.547op/s 9790213.702op/s 0.52% -2.047 5.127 0.66% 4566.195op/s 1 200
credit_card/is_card_number/37828224631 execution_time 1.211µs 1.212µs ± 0.001µs 1.212µs ± 0.000µs 1.213µs 1.213µs 1.214µs 1.218µs 0.50% 2.438 16.197 0.06% 0.000µs 1 200
credit_card/is_card_number/37828224631 throughput 820806448.306op/s 824803586.555op/s ± 520844.727op/s 824893047.940op/s ± 309995.731op/s 825093630.200op/s 825495802.162op/s 825563165.450op/s 825711916.240op/s 0.10% -2.415 15.974 0.06% 36829.284op/s 1 200
credit_card/is_card_number/378282246310005 execution_time 98.510µs 99.480µs ± 0.821µs 99.214µs ± 0.424µs 99.798µs 101.222µs 102.051µs 102.632µs 3.44% 1.428 1.876 0.82% 0.058µs 1 200
credit_card/is_card_number/378282246310005 throughput 9743548.830op/s 10052923.256op/s ± 82046.487op/s 10079172.398op/s ± 43089.115op/s 10111813.465op/s 10140983.271op/s 10149324.521op/s 10151266.943op/s 0.72% -1.384 1.708 0.81% 5801.563op/s 1 200
credit_card/is_card_number/37828224631000521389798 execution_time 100.071µs 100.471µs ± 0.367µs 100.381µs ± 0.188µs 100.642µs 100.974µs 101.492µs 103.297µs 2.91% 3.248 19.046 0.36% 0.026µs 1 200
credit_card/is_card_number/37828224631000521389798 throughput 9680793.267op/s 9953207.827op/s ± 35967.024op/s 9962031.709op/s ± 18626.276op/s 9977869.338op/s 9988331.631op/s 9990735.791op/s 9992885.066op/s 0.31% -3.136 17.923 0.36% 2543.253op/s 1 200
credit_card/is_card_number/x371413321323331 execution_time 19.285µs 19.446µs ± 0.118µs 19.445µs ± 0.088µs 19.526µs 19.676µs 19.726µs 19.871µs 2.19% 0.667 0.284 0.61% 0.008µs 1 200
credit_card/is_card_number/x371413321323331 throughput 50325170.114op/s 51426659.499op/s ± 310692.641op/s 51426837.133op/s ± 234130.978op/s 51691868.076op/s 51830704.081op/s 51848361.088op/s 51854499.503op/s 0.83% -0.634 0.197 0.60% 21969.287op/s 1 200
credit_card/is_card_number_no_luhn/ execution_time 1.212µs 1.213µs ± 0.000µs 1.212µs ± 0.000µs 1.213µs 1.213µs 1.214µs 1.215µs 0.21% 1.287 2.792 0.04% 0.000µs 1 200
credit_card/is_card_number_no_luhn/ throughput 823049867.321op/s 824703821.195op/s ± 327423.416op/s 824771837.630op/s ± 223923.353op/s 824971642.538op/s 825053865.604op/s 825124543.905op/s 825165145.593op/s 0.05% -1.283 2.771 0.04% 23152.332op/s 1 200
credit_card/is_card_number_no_luhn/ 3782-8224-6310-005 execution_time 89.204µs 91.145µs ± 0.605µs 91.121µs ± 0.374µs 91.517µs 92.171µs 92.694µs 93.417µs 2.52% 0.214 0.860 0.66% 0.043µs 1 200
credit_card/is_card_number_no_luhn/ 3782-8224-6310-005 throughput 10704666.807op/s 10971952.980op/s ± 72699.234op/s 10974404.956op/s ± 44988.363op/s 11017573.923op/s 11085337.910op/s 11121619.793op/s 11210205.935op/s 2.15% -0.159 0.809 0.66% 5140.612op/s 1 200
credit_card/is_card_number_no_luhn/ 378282246310005 execution_time 82.881µs 84.643µs ± 0.602µs 84.677µs ± 0.500µs 85.130µs 85.475µs 85.777µs 85.913µs 1.46% -0.247 -0.534 0.71% 0.043µs 1 200
credit_card/is_card_number_no_luhn/ 378282246310005 throughput 11639726.406op/s 11814913.998op/s ± 84139.628op/s 11809583.472op/s ± 69498.682op/s 11880721.159op/s 11952640.551op/s 11999732.143op/s 12065512.284op/s 2.17% 0.277 -0.507 0.71% 5949.570op/s 1 200
credit_card/is_card_number_no_luhn/37828224631 execution_time 1.212µs 1.213µs ± 0.001µs 1.212µs ± 0.000µs 1.213µs 1.213µs 1.215µs 1.222µs 0.78% 6.588 61.092 0.07% 0.000µs 1 200
credit_card/is_card_number_no_luhn/37828224631 throughput 818356668.768op/s 824679184.937op/s ± 607441.405op/s 824765112.438op/s ± 234799.587op/s 825003858.453op/s 825111417.678op/s 825168341.948op/s 825192874.327op/s 0.05% -6.545 60.452 0.07% 42952.594op/s 1 200
credit_card/is_card_number_no_luhn/378282246310005 execution_time 79.657µs 81.160µs ± 0.579µs 81.193µs ± 0.366µs 81.538µs 81.981µs 82.152µs 83.653µs 3.03% 0.086 1.130 0.71% 0.041µs 1 200
credit_card/is_card_number_no_luhn/378282246310005 throughput 11954133.532op/s 12322028.952op/s ± 87852.577op/s 12316260.515op/s ± 55492.226op/s 12375031.255op/s 12472541.078op/s 12538814.196op/s 12553844.858op/s 1.93% -0.021 1.000 0.71% 6212.115op/s 1 200
credit_card/is_card_number_no_luhn/37828224631000521389798 execution_time 100.093µs 100.558µs ± 0.421µs 100.444µs ± 0.181µs 100.677µs 101.361µs 101.780µs 103.509µs 3.05% 2.658 12.137 0.42% 0.030µs 1 200
credit_card/is_card_number_no_luhn/37828224631000521389798 throughput 9660982.595op/s 9944727.916op/s ± 41163.118op/s 9955749.224op/s ± 17974.006op/s 9970412.552op/s 9985355.578op/s 9989622.031op/s 9990662.727op/s 0.35% -2.572 11.330 0.41% 2910.672op/s 1 200
credit_card/is_card_number_no_luhn/x371413321323331 execution_time 19.240µs 19.395µs ± 0.125µs 19.400µs ± 0.101µs 19.478µs 19.639µs 19.718µs 19.920µs 2.68% 0.867 0.850 0.64% 0.009µs 1 200
credit_card/is_card_number_no_luhn/x371413321323331 throughput 50201496.744op/s 51561345.011op/s ± 331170.853op/s 51547470.552op/s ± 268884.682op/s 51870821.450op/s 51965266.196op/s 51971614.821op/s 51973895.003op/s 0.83% -0.828 0.701 0.64% 23417.316op/s 1 200
scenario metric 95% CI mean Shapiro-Wilk pvalue Ljung-Box pvalue (lag=1) Dip test pvalue
credit_card/is_card_number/ execution_time [1.212µs; 1.212µs] or [-0.008%; +0.008%] None None None
credit_card/is_card_number/ throughput [824743951.321op/s; 824867931.934op/s] or [-0.008%; +0.008%] None None None
credit_card/is_card_number/ 3782-8224-6310-005 execution_time [109.040µs; 109.223µs] or [-0.084%; +0.084%] None None None
credit_card/is_card_number/ 3782-8224-6310-005 throughput [9155955.619op/s; 9171198.463op/s] or [-0.083%; +0.083%] None None None
credit_card/is_card_number/ 378282246310005 execution_time [102.818µs; 103.010µs] or [-0.093%; +0.093%] None None None
credit_card/is_card_number/ 378282246310005 throughput [9708333.974op/s; 9726233.129op/s] or [-0.092%; +0.092%] None None None
credit_card/is_card_number/37828224631 execution_time [1.212µs; 1.213µs] or [-0.009%; +0.009%] None None None
credit_card/is_card_number/37828224631 throughput [824731402.485op/s; 824875770.625op/s] or [-0.009%; +0.009%] None None None
credit_card/is_card_number/378282246310005 execution_time [99.366µs; 99.594µs] or [-0.114%; +0.114%] None None None
credit_card/is_card_number/378282246310005 throughput [10041552.402op/s; 10064294.110op/s] or [-0.113%; +0.113%] None None None
credit_card/is_card_number/37828224631000521389798 execution_time [100.421µs; 100.522µs] or [-0.051%; +0.051%] None None None
credit_card/is_card_number/37828224631000521389798 throughput [9948223.143op/s; 9958192.511op/s] or [-0.050%; +0.050%] None None None
credit_card/is_card_number/x371413321323331 execution_time [19.430µs; 19.462µs] or [-0.084%; +0.084%] None None None
credit_card/is_card_number/x371413321323331 throughput [51383600.487op/s; 51469718.511op/s] or [-0.084%; +0.084%] None None None
credit_card/is_card_number_no_luhn/ execution_time [1.212µs; 1.213µs] or [-0.006%; +0.006%] None None None
credit_card/is_card_number_no_luhn/ throughput [824658443.459op/s; 824749198.932op/s] or [-0.006%; +0.006%] None None None
credit_card/is_card_number_no_luhn/ 3782-8224-6310-005 execution_time [91.062µs; 91.229µs] or [-0.092%; +0.092%] None None None
credit_card/is_card_number_no_luhn/ 3782-8224-6310-005 throughput [10961877.566op/s; 10982028.395op/s] or [-0.092%; +0.092%] None None None
credit_card/is_card_number_no_luhn/ 378282246310005 execution_time [84.560µs; 84.726µs] or [-0.099%; +0.099%] None None None
credit_card/is_card_number_no_luhn/ 378282246310005 throughput [11803253.055op/s; 11826574.941op/s] or [-0.099%; +0.099%] None None None
credit_card/is_card_number_no_luhn/37828224631 execution_time [1.212µs; 1.213µs] or [-0.010%; +0.010%] None None None
credit_card/is_card_number_no_luhn/37828224631 throughput [824594999.400op/s; 824763370.473op/s] or [-0.010%; +0.010%] None None None
credit_card/is_card_number_no_luhn/378282246310005 execution_time [81.079µs; 81.240µs] or [-0.099%; +0.099%] None None None
credit_card/is_card_number_no_luhn/378282246310005 throughput [12309853.430op/s; 12334204.474op/s] or [-0.099%; +0.099%] None None None
credit_card/is_card_number_no_luhn/37828224631000521389798 execution_time [100.499µs; 100.616µs] or [-0.058%; +0.058%] None None None
credit_card/is_card_number_no_luhn/37828224631000521389798 throughput [9939023.104op/s; 9950432.728op/s] or [-0.057%; +0.057%] None None None
credit_card/is_card_number_no_luhn/x371413321323331 execution_time [19.378µs; 19.413µs] or [-0.090%; +0.090%] None None None
credit_card/is_card_number_no_luhn/x371413321323331 throughput [51515447.915op/s; 51607242.106op/s] or [-0.089%; +0.089%] None None None

Group 8

cpu_model git_commit_sha git_commit_date git_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz 302f257 1726055434 gleocadie/add-crashtracking-feature-for-windows
scenario metric min mean ± sd median ± mad p75 p95 p99 max peak_to_median_ratio skewness kurtosis cv sem runs sample_size
normalization/normalize_name/normalize_name/Too-Long-.Too-Long-.Too-Long-.Too-Long-.Too-Long-.Too-Lo... execution_time 280.755µs 282.064µs ± 0.958µs 281.792µs ± 0.534µs 282.576µs 283.942µs 284.685µs 285.844µs 1.44% 1.270 1.591 0.34% 0.068µs 1 200
normalization/normalize_name/normalize_name/Too-Long-.Too-Long-.Too-Long-.Too-Long-.Too-Long-.Too-Lo... throughput 3498408.345op/s 3545340.972op/s ± 11990.076op/s 3548714.955op/s ± 6725.953op/s 3554546.121op/s 3558609.885op/s 3559316.835op/s 3561821.304op/s 0.37% -1.250 1.509 0.34% 847.826op/s 1 200
normalization/normalize_name/normalize_name/bad-name execution_time 27.711µs 27.796µs ± 0.041µs 27.792µs ± 0.027µs 27.822µs 27.872µs 27.898µs 27.930µs 0.50% 0.474 -0.022 0.15% 0.003µs 1 200
normalization/normalize_name/normalize_name/bad-name throughput 35803287.282op/s 35976222.737op/s ± 53591.724op/s 35981931.648op/s ± 35076.536op/s 36012095.308op/s 36050874.944op/s 36074245.919op/s 36086383.995op/s 0.29% -0.466 -0.033 0.15% 3789.507op/s 1 200
normalization/normalize_name/normalize_name/good execution_time 16.855µs 16.905µs ± 0.031µs 16.900µs ± 0.023µs 16.928µs 16.957µs 16.989µs 16.998µs 0.58% 0.562 -0.362 0.18% 0.002µs 1 200
normalization/normalize_name/normalize_name/good throughput 58830450.641op/s 59155884.739op/s ± 108776.655op/s 59171200.436op/s ± 79561.242op/s 59241337.517op/s 59300131.899op/s 59319426.037op/s 59328599.676op/s 0.27% -0.555 -0.376 0.18% 7691.671op/s 1 200
scenario metric 95% CI mean Shapiro-Wilk pvalue Ljung-Box pvalue (lag=1) Dip test pvalue
normalization/normalize_name/normalize_name/Too-Long-.Too-Long-.Too-Long-.Too-Long-.Too-Long-.Too-Lo... execution_time [281.931µs; 282.196µs] or [-0.047%; +0.047%] None None None
normalization/normalize_name/normalize_name/Too-Long-.Too-Long-.Too-Long-.Too-Long-.Too-Long-.Too-Lo... throughput [3543679.263op/s; 3547002.681op/s] or [-0.047%; +0.047%] None None None
normalization/normalize_name/normalize_name/bad-name execution_time [27.790µs; 27.802µs] or [-0.021%; +0.021%] None None None
normalization/normalize_name/normalize_name/bad-name throughput [35968795.440op/s; 35983650.035op/s] or [-0.021%; +0.021%] None None None
normalization/normalize_name/normalize_name/good execution_time [16.900µs; 16.909µs] or [-0.026%; +0.026%] None None None
normalization/normalize_name/normalize_name/good throughput [59140809.341op/s; 59170960.137op/s] or [-0.025%; +0.025%] None None None

Group 9

cpu_model git_commit_sha git_commit_date git_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz 302f257 1726055434 gleocadie/add-crashtracking-feature-for-windows
scenario metric min mean ± sd median ± mad p75 p95 p99 max peak_to_median_ratio skewness kurtosis cv sem runs sample_size
redis/obfuscate_redis_string execution_time 36.757µs 37.083µs ± 0.555µs 36.836µs ± 0.023µs 36.881µs 38.209µs 38.267µs 40.466µs 9.86% 2.328 6.482 1.49% 0.039µs 1 200
scenario metric 95% CI mean Shapiro-Wilk pvalue Ljung-Box pvalue (lag=1) Dip test pvalue
redis/obfuscate_redis_string execution_time [37.006µs; 37.160µs] or [-0.208%; +0.208%] None None None

Group 10

cpu_model git_commit_sha git_commit_date git_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz 302f257 1726055434 gleocadie/add-crashtracking-feature-for-windows
scenario metric min mean ± sd median ± mad p75 p95 p99 max peak_to_median_ratio skewness kurtosis cv sem runs sample_size
two way interface execution_time 17.679µs 25.754µs ± 10.849µs 18.091µs ± 0.313µs 35.344µs 36.339µs 42.785µs 94.662µs 423.25% 2.405 11.803 42.02% 0.767µs 1 200
scenario metric 95% CI mean Shapiro-Wilk pvalue Ljung-Box pvalue (lag=1) Dip test pvalue
two way interface execution_time [24.250µs; 27.257µs] or [-5.839%; +5.839%] None None None

Group 11

cpu_model git_commit_sha git_commit_date git_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz 302f257 1726055434 gleocadie/add-crashtracking-feature-for-windows
scenario metric min mean ± sd median ± mad p75 p95 p99 max peak_to_median_ratio skewness kurtosis cv sem runs sample_size
write only interface execution_time 1.456µs 3.249µs ± 1.580µs 3.093µs ± 0.033µs 3.120µs 3.187µs 13.930µs 18.324µs 492.41% 7.967 64.667 48.51% 0.112µs 1 200
scenario metric 95% CI mean Shapiro-Wilk pvalue Ljung-Box pvalue (lag=1) Dip test pvalue
write only interface execution_time [3.030µs; 3.468µs] or [-6.740%; +6.740%] None None None

Group 12

cpu_model git_commit_sha git_commit_date git_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz 302f257 1726055434 gleocadie/add-crashtracking-feature-for-windows
scenario metric min mean ± sd median ± mad p75 p95 p99 max peak_to_median_ratio skewness kurtosis cv sem runs sample_size
tags/replace_trace_tags execution_time 2.708µs 2.741µs ± 0.013µs 2.741µs ± 0.008µs 2.749µs 2.761µs 2.769µs 2.773µs 1.17% 0.005 -0.386 0.46% 0.001µs 1 200
scenario metric 95% CI mean Shapiro-Wilk pvalue Ljung-Box pvalue (lag=1) Dip test pvalue
tags/replace_trace_tags execution_time [2.739µs; 2.742µs] or [-0.064%; +0.064%] None None None

Baseline

Omitted due to size.

@gleocadie gleocadie force-pushed the gleocadie/add-crashtracking-feature-for-windows branch 3 times, most recently from 9fcbe37 to feab5ef Compare September 6, 2024 23:15
@gleocadie gleocadie changed the base branch from main to gleocadie/fix-missing-symbol-for-crashtracker September 6, 2024 23:16
@gleocadie gleocadie force-pushed the gleocadie/add-crashtracking-feature-for-windows branch from feab5ef to d68c437 Compare September 6, 2024 23:17
@github-actions github-actions bot removed the profiling Relates to the profiling* modules. label Sep 6, 2024
@gleocadie gleocadie force-pushed the gleocadie/fix-missing-symbol-for-crashtracker branch from 061205f to 2d9e34e Compare September 6, 2024 23:46
@gleocadie gleocadie force-pushed the gleocadie/add-crashtracking-feature-for-windows branch from d68c437 to e0ba478 Compare September 6, 2024 23:47
@gleocadie gleocadie changed the title Gleocadie/add crashtracking feature for windows Add crashtracking feature for windows (event it's not ready yet) Sep 6, 2024
@gleocadie gleocadie changed the base branch from gleocadie/fix-missing-symbol-for-crashtracker to main September 10, 2024 12:14
@gleocadie gleocadie changed the title Add crashtracking feature for windows (event it's not ready yet) [Profiling/Build] Add crashtracking feature for windows (event it's not ready yet) Sep 10, 2024
@gleocadie gleocadie force-pushed the gleocadie/add-crashtracking-feature-for-windows branch from e0ba478 to b41b28e Compare September 11, 2024 07:33
@gleocadie gleocadie marked this pull request as ready for review September 11, 2024 07:33
@gleocadie gleocadie requested a review from a team as a code owner September 11, 2024 07:33
@gleocadie gleocadie force-pushed the gleocadie/add-crashtracking-feature-for-windows branch 3 times, most recently from 21b6e81 to 3dbd318 Compare September 11, 2024 11:44
@gleocadie gleocadie force-pushed the gleocadie/add-crashtracking-feature-for-windows branch from 3dbd318 to 302f257 Compare September 11, 2024 11:50
ivoanjo
ivoanjo approved these changes Sep 11, 2024
View reviewed changes
Copy link
Member

@ivoanjo ivoanjo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's hard for most of us to try this out without access to a windows machine, but on the other hand the change does look reasonable + it has a really tiny blast radius, so I see no reason not to merge it :)

.github/workflows/test.yml
Comment on lines +164 to 167
rm -rf examples/ffi/build_dll
mkdir examples/ffi/build_dll
cd examples/ffi/build_dll
cmake -S .. -DDatadog_ROOT=$LIBDD_OUTPUT_FOLDER -DVCRUNTIME_LINK_TYPE=DLL
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor: Is this getting cached from run to run that it needs to clean the folder? 👀

Copy link
Contributor Author

@gleocadie gleocadie Sep 11, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

To be honest I do not know. But I observed FFI steps failing: symbolizer could not run because libdatadog_profiling_ffi.so was missing (there is no libdatadog_profiling_ffi.so anymore, it's renamed into libdatadog_profiling.so

When I added this line, the issue went away. (mainly for the ubuntu-latest ones)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

image
https://github.com/DataDog/libdatadog/actions/runs/10809534184/job/29984846615

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks suspiciously exactly like the issue @AlexJF ran into in #408 ...

@gleocadie
Copy link
Contributor Author

gleocadie commented Sep 11, 2024 •
edited
Loading

It's hard for most of us to try this out without access to a windows machine, but on the other hand the change does look reasonable + it has a really tiny blast radius, so I see no reason not to merge it :)

The package is run on every PR in Gitlab. At least, if files were missing or the names have changed, it would have failed.
But yeah, in my case, I downloaded the nuget package, updated the project with it and built the project.

I plan to add tests:

  • one on the exported symbols
  • one on "if the package is correct and be used in a vcxproj (C++ project with Visual Studio)"

@gleocadie gleocadie merged commit 4bf5106 into main Sep 12, 2024
30 checks passed
@gleocadie gleocadie deleted the gleocadie/add-crashtracking-feature-for-windows branch September 12, 2024 07:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ivoanjo ivoanjo ivoanjo approved these changes

@hoolioh hoolioh hoolioh approved these changes

@bantonsson bantonsson bantonsson approved these changes

Assignees
No one assigned
Labels
ci-build
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@gleocadie @codecov-commenter @bantonsson @ivoanjo @hoolioh