-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Training2 #22
Open
surbhigoel77
wants to merge
34
commits into
main
Choose a base branch
from
training2
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Training2 #22
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
surbhigoel77
requested review from
jatkinson1000
and removed request for
jatkinson1000
August 5, 2024 11:30
…iles to loaddata from train.py
…train and deleted commented out code in model
surbhigoel77
force-pushed
the
training2
branch
from
August 13, 2024 09:58
5d58a52
to
6a8d1ea
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rebasing the current net with main
Closes #19
In order to accomodate data coming from multiple sources, we need to replace the hardcoded inputs with variables whose values are extracted from the dataset during the code run.
Files updated:
loaddata.py
Model.py
train.py
Files Removed:
Files Added:
main.py
In
train.py
, the.nc
data files are read and the variables are extracted and normalised. This part should be taken out oftrain.py
and be kept in a separatepreprocessing.py
file, to keep train.py common for different data sources.train.py
can be converted into a module instead. We can also have a test notebook in the repo.