Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: update framework to .net 8.0 #9

Merged
merged 5 commits into from
Oct 24, 2024
Merged

feat: update framework to .net 8.0 #9

merged 5 commits into from
Oct 24, 2024

Conversation

umoelli
Copy link
Member

@umoelli umoelli commented Oct 2, 2024

  • update framework to .net 8
  • update libraries
  • add new environment 'Terminfinder__dbmigrate' with the same function as the argument '--dbmigrate'
  • modification of dockerfiles and docker compose, especially for postgres

Copy link
Member

@tjorbo tjorbo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @umoelli
Danke für deine Änderungen! 🍀

Der Container für die Dev-DB ist eine gute Idee! Wir bräuchten nur noch das Script, was kopiert werden soll und dann ists echt komfortabel zu entwickeln. Danke!

tjorbo
tjorbo previously requested changes Oct 15, 2024
Copy link
Member

@tjorbo tjorbo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @umoelli
habe noch den User umgestellt, damit der Postgres Server nicht als Root läuft und das initdb script ausgeführt.

Bei mir startet die DB nun und kann Verbindungen annehmen.

Comment on lines +8 to +11
WORKDIR /app
EXPOSE 5432

COPY create_user.sql /docker-entrypoint-initdb.d
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
WORKDIR /app
EXPOSE 5432
COPY create_user.sql /docker-entrypoint-initdb.d
EXPOSE 5432
COPY create_user.sql /docker-entrypoint-initdb.d
USER "999:999"
RUN initdb

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unter Windows/WSL2 verursacht die Änderung eine Fehlermeldung. Da das Dockerfile nichts mit der .Net 8 Migration zu tun hat, sollten wir das Thema später betrachten.

@umoelli umoelli dismissed tjorbo’s stale review October 24, 2024 07:06

Die Dockeranpassung läuft nicht unter Windows/WSL2 und hat vorrangig nichts mit der .Net 8 Migration zu tun (=> Änderung wird auf einen späteren Zeitpunkt verschoben)

@umoelli umoelli merged commit 32b5c2a into main Oct 24, 2024
1 check passed
@tjorbo tjorbo deleted the feature/dotnet-8 branch November 7, 2024 09:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants