Replace setup.py with pyproject.toml #490
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I was looking at how python packaging worked and discovered the existence of PEP621.
This is a more standard and up-to-date alternative to the setup.py script
I think this is also more readable and will facilitate extending glad with new generators, as was discussed in #489.
I have also added Vulkan/VK to the description and keywords. This seemed missing.
The setup.py's
long_descriptionparameter is replaced with thereadmefield of the[project]table. I have put the current description in long_description.md, but maybe the README file could be reworked, or just used as is, instead.I have put
fortranas an optional dependency following #488 , but this has not been released yet.