Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix JavaScript variable dartPdfJsBaseUrl access from Dart #1707

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Fix JavaScript variable dartPdfJsBaseUrl access from Dart #1707

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion printing/lib/printing_web.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -95,7 +95,7 @@ class PrintingPlugin extends PrintingPlatform {
// Check if the source of PDF.js library is overridden via
// [dartPdfJsBaseUrl] JavaScript variable.
if (web.window.hasProperty(_dartPdfJsBaseUrl.toJS).toDart) {
_pdfJsUrlBase = web.window.getProperty(_dartPdfJsBaseUrl.toJS);
_pdfJsUrlBase = web.window.getProperty<js.JSString?>(_dartPdfJsBaseUrl.toJS)!.toDart;
} else {
final pdfJsVersion =
web.window.hasProperty(_dartPdfJsVersion.toJS).toDart
Expand Down