feat: ability to create a closed deal by specifying the close dates &…

… convert some date fields from string to DateTime
DavidRouyer · Oct 9, 2018 · f6ad38d · f6ad38d
1 parent 96cb780
commit f6ad38d
Show file tree

Hide file tree

Showing 7 changed files with 52 additions and 21 deletions.
diff --git a/src/Pipedrive.net/Models/Request/DealUpdate.cs b/src/Pipedrive.net/Models/Request/DealUpdate.cs
@@ -40,12 +40,24 @@ public class DealUpdate : IEntityWithCustomFields
         [JsonProperty("lost_reason")]
         public string LostReason { get; set; }
 
-        [JsonProperty("add_time")]
-        public DateTime AddTime { get; set; }
-
         [JsonProperty("visible_to")]
         public Visibility VisibleTo { get; set; }
 
+        [JsonProperty("add_time")]
+        public DateTime? AddTime { get; set; }
+
+        [JsonProperty("close_time")]
+        public DateTime? CloseTime { get; set; }
+
+        [JsonProperty("lost_time")]
+        public DateTime? LostTime { get; set; }
+
+        [JsonProperty("first_won_time")]
+        public DateTime? FirstWonTime { get; set; }
+
+        [JsonProperty("won_time")]
+        public DateTime? WonTime { get; set; }
+
         [JsonIgnore]
         public IDictionary<string, ICustomField> CustomFields { get; set; }
     }

diff --git a/src/Pipedrive.net/Models/Request/NewDeal.cs b/src/Pipedrive.net/Models/Request/NewDeal.cs
@@ -1,5 +1,6 @@
 using Newtonsoft.Json;
 using Newtonsoft.Json.Converters;
+using System;
 using System.Collections.Generic;
 
 namespace Pipedrive
@@ -41,7 +42,19 @@ public class NewDeal : IEntityWithCustomFields
         public Visibility VisibleTo { get; set; }
 
         [JsonProperty("add_time")]
-        public string AddTime { get; set; }
+        public DateTime? AddTime { get; set; }
+
+        [JsonProperty("close_time")]
+        public DateTime? CloseTime { get; set; }
+
+        [JsonProperty("lost_time")]
+        public DateTime? LostTime { get; set; }
+
+        [JsonProperty("first_won_time")]
+        public DateTime? FirstWonTime { get; set; }
+
+        [JsonProperty("won_time")]
+        public DateTime? WonTime { get; set; }
 
         [JsonIgnore]
         public IDictionary<string, ICustomField> CustomFields { get; set; } = new Dictionary<string, ICustomField>();

diff --git a/src/Pipedrive.net/Models/Request/NewOrganization.cs b/src/Pipedrive.net/Models/Request/NewOrganization.cs
@@ -1,4 +1,5 @@
 using Newtonsoft.Json;
+using System;
 using System.Collections.Generic;
 
 namespace Pipedrive
@@ -15,7 +16,7 @@ public class NewOrganization : IEntityWithCustomFields
         public Visibility VisibleTo { get; set; }
 
         [JsonProperty("add_time")]
-        public string AddTime { get; set; }
+        public DateTime? AddTime { get; set; }
 
         [JsonIgnore]
         public IDictionary<string, ICustomField> CustomFields { get; set; } = new Dictionary<string, ICustomField>();

diff --git a/src/Pipedrive.net/Models/Request/NewPerson.cs b/src/Pipedrive.net/Models/Request/NewPerson.cs
@@ -1,4 +1,5 @@
 using Newtonsoft.Json;
+using System;
 using System.Collections.Generic;
 
 namespace Pipedrive
@@ -24,7 +25,7 @@ public class NewPerson : IEntityWithCustomFields
         public Visibility VisibleTo { get; set; }
 
         [JsonProperty("add_time")]
-        public string AddTime { get; set; }
+        public DateTime? AddTime { get; set; }
 
         [JsonIgnore]
         public IDictionary<string, ICustomField> CustomFields { get; set; } = new Dictionary<string, ICustomField>();

diff --git a/src/Pipedrive.net/Models/Response/Deal.cs b/src/Pipedrive.net/Models/Response/Deal.cs
@@ -78,19 +78,19 @@ public class Deal : IEntityWithCustomFields
         public Visibility VisibleTo { get; set; }
 
         [JsonProperty("close_time")]
-        public string CloseTime { get; set; }
+        public DateTime? CloseTime { get; set; }
 
         [JsonProperty("pipeline_id")]
         public long PipelineId { get; set; }
 
         [JsonProperty("won_time")]
-        public string WonTime { get; set; }
+        public DateTime? WonTime { get; set; }
 
         [JsonProperty("first_won_time")]
-        public string FirstWonTime { get; set; }
+        public DateTime? FirstWonTime { get; set; }
 
         [JsonProperty("lost_time")]
-        public string LostTime { get; set; }
+        public DateTime? LostTime { get; set; }
 
         [JsonProperty("products_count")]
         public int ProductsCount { get; set; }
@@ -126,10 +126,10 @@ public class Deal : IEntityWithCustomFields
         public DateTime? ExpectedCloseDate { get; set; }
 
         [JsonProperty("last_incoming_mail_time")]
-        public string LastIncomingMailTime { get; set; }
+        public DateTime? LastIncomingMailTime { get; set; }
 
         [JsonProperty("last_outgoing_mail_time")]
-        public string LastOutgoingMailTime { get; set; }
+        public DateTime? LastOutgoingMailTime { get; set; }
 
         [JsonProperty("stage_order_nr")]
         public int StageOrderNr { get; set; }
@@ -193,8 +193,12 @@ public DealUpdate ToUpdate()
                 Status = Status,
                 Probability = Probability,
                 LostReason = LostReason,
-                AddTime = AddTime,
                 VisibleTo = VisibleTo,
+                AddTime = AddTime,
+                CloseTime = CloseTime,
+                LostTime = LostTime,
+                FirstWonTime = FirstWonTime,
+                WonTime = WonTime,
                 CustomFields = CustomFields
             };
         }

diff --git a/src/Pipedrive.net/Models/Response/Person.cs b/src/Pipedrive.net/Models/Response/Person.cs
@@ -129,10 +129,10 @@ public class Person : IEntityWithCustomFields
         public string TimelineLastActivityTimeByOwner { get; set; }
 
         [JsonProperty("last_incoming_mail_time")]
-        public string LastIncomingMailTime { get; set; }
+        public DateTime? LastIncomingMailTime { get; set; }
 
         [JsonProperty("last_outgoing_mail_time")]
-        public string LastOutgoingMailTime { get; set; }
+        public DateTime? LastOutgoingMailTime { get; set; }
 
         [JsonProperty("org_name")]
         public string OrgName { get; set; }

diff --git a/src/Pipedrive.net/Models/Response/WebhookDeal.cs b/src/Pipedrive.net/Models/Response/WebhookDeal.cs
@@ -77,19 +77,19 @@ public class WebhookDeal : IEntityWithCustomFields
         public Visibility VisibleTo { get; set; }
 
         [JsonProperty("close_time")]
-        public string CloseTime { get; set; }
+        public DateTime? CloseTime { get; set; }
 
         [JsonProperty("pipeline_id")]
         public long PipelineId { get; set; }
 
         [JsonProperty("won_time")]
-        public string WonTime { get; set; }
+        public DateTime? WonTime { get; set; }
 
         [JsonProperty("first_won_time")]
-        public string FirstWonTime { get; set; }
+        public DateTime? FirstWonTime { get; set; }
 
         [JsonProperty("lost_time")]
-        public string LostTime { get; set; }
+        public DateTime? LostTime { get; set; }
 
         [JsonProperty("products_count")]
         public int ProductsCount { get; set; }
@@ -125,10 +125,10 @@ public class WebhookDeal : IEntityWithCustomFields
         public DateTime? ExpectedCloseDate { get; set; }
 
         [JsonProperty("last_incoming_mail_time")]
-        public string LastIncomingMailTime { get; set; }
+        public DateTime? LastIncomingMailTime { get; set; }
 
         [JsonProperty("last_outgoing_mail_time")]
-        public string LastOutgoingMailTime { get; set; }
+        public DateTime? LastOutgoingMailTime { get; set; }
 
         [JsonProperty("stage_order_nr")]
         public int StageOrderNr { get; set; }