🌌👷♂️ ↝ Adding Docker, Flake & Actions config #3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…g repo structure and flask boilerplate from signal-k/sytizen (derived from issue: Signal-K/sytizen#18)
Gizmotronn
added
documentation
Gizmotronn
commented
Feb 17, 2023
| @@ -0,0 +1,36 @@ | |||
| name: Python Container for Text Extraction | |||
There was a problem hiding this comment.
Nice to have automated pip installs that actually work (unix superiority). However, due to running/linting with Flake8 after line 28 we'll no doubt run into errors with most of the Python files in the repository. For this reason, I'll be fixing this by reducing the majority of the flask boilerplate code to an SPA that calls the full flask app/notebook at Signal-K/sytizen#18 / Signal-K/Silfur#24)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
, as well as reorganising repo structure and flask boilerplate from signal-k/sytizen (derived from issue: Signal-K/sytizen#18)
There will be some issues with Flake & Actions as our Python & Jupyter notebooks are not fully imported (there are a number of errors in
app.pyalone) -> so we'll likely add thesignal-k/sytizenas a submodule like with thesignal-k/clientrepository, focusing on the server, while importing from specific files inside the submodule down the line.