Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(progressbars): add rounded corner to progress bars #157

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

fix(progressbars): add rounded corner to progress bars #157

wants to merge 2 commits into from

Conversation

FDELAHA24
Copy link
Contributor

@FDELAHA24 FDELAHA24 commented Jun 16, 2023 •
edited
Loading

Changes description 🧑‍💻

Add rounded corner to progress bars

Context 🤔

Closes #140

Checklist ✅

  • Make sure you are requesting to pull a topic/feature/bugfix branch. Please, don't request directly from your main!
  • Check commits & PR names matches our requested structure. It must follow the https://www.conventionalcommits.org pattern.
  • Check compose contract convention. It must follow conventions described here.
  • Check your code additions will fail neither code linting checks.
  • I have reviewed the submitted code.
  • I have tested on a phone device/emulator.
  • I have tested on a tablet device/emulator.
  • I have tested on a large screen device/emulator.
  • If it includes design changes, please ask for a review design-system-core-team-design GitHub team.

Screenshots 📸

Screenshot_20230616_161540

Other info 👋

We must merge the following PR first, to benefit from versions upgrades

@FDELAHA24 FDELAHA24 requested review from ManonPolle and a team as code owners June 16, 2023 14:17
@FDELAHA24 FDELAHA24 self-assigned this Jun 16, 2023
@FDELAHA24 FDELAHA24 requested a review from a team June 16, 2023 14:18
@FDELAHA24 FDELAHA24 changed the title Fix/progress rounded corner fix(progressbars): add rounded corner to progress bars Jun 16, 2023
@FDELAHA24 FDELAHA24 force-pushed the fix/progress_rounded_corner branch from 3a4bdb7 to 844ac31 Compare June 16, 2023 14:46
@FDELAHA24 FDELAHA24 force-pushed the fix/progress_rounded_corner branch from 844ac31 to c0f3c9a Compare June 30, 2023 14:36
@FDELAHA24 FDELAHA24 force-pushed the fix/progress_rounded_corner branch from c0f3c9a to 8b43440 Compare July 5, 2023 07:14
@dktbitrise
Copy link

You can download the apk here :

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ManonPolle ManonPolle Awaiting requested review from ManonPolle ManonPolle is a code owner

At least 1 approving review is required to merge this pull request.

Assignees

@FDELAHA24 FDELAHA24

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Rounded Corner Progressbar Circle
3 participants
@FDELAHA24 @dktbitrise @ManonPolle