-
Notifications
You must be signed in to change notification settings - Fork 11
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
feat(modifiers): adds responsive functionality to modifiers utils (#23)
* feat(enhance modifiers): adds responsive functionality to modifiers utils * chore(enhance-modifiers): bumps version * chore(enhanced modifiers): rename some internals * chore(enhanced modifiers): cleanups after review * feat(typescript): ports library to typescript (#24) * feat(adding typescript): adds typescript to the library * fix ci * Suggestions for improved typings and build processes (#26) * wip * task(DDS-83) enhances typings and build processes * fix(DDS-83): restores 100% test coverage * task(DDS-83): removes extra type import * feat(types) adds generics to typings * chore(cleanups): improve typings * chore([DDS-83]): cleanups after review * chore(version): sets version to correct value
- Loading branch information
Andrew T. Poe
authored
May 24, 2019
1 parent
7e012fa
commit 24ffb82
Showing
41 changed files
with
5,556 additions
and
2,965 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,4 @@ | ||
*.tsbuildinfo | ||
.eslint* | ||
package.json | ||
tsconfig.json |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,51 @@ | ||
module.exports = { | ||
root: true, | ||
parser: '@typescript-eslint/parser', | ||
plugins: ['import', '@typescript-eslint', 'jest'], | ||
extends: [ | ||
'airbnb-base', | ||
'plugin:prettier/recommended', | ||
'plugin:@typescript-eslint/recommended', | ||
], | ||
env: { | ||
commonjs: true, | ||
es6: true, | ||
jest: true, | ||
node: true, | ||
}, | ||
parserOptions: { | ||
ecmaVersion: 6, | ||
sourceType: 'module', | ||
ecmaFeatures: { | ||
jsx: true, | ||
}, | ||
project: './tsconfig.json', | ||
tsconfigRootDir: '.', | ||
}, | ||
settings: { | ||
'import/resolver': { | ||
typescript: {}, | ||
}, | ||
}, | ||
rules: { | ||
'prettier/prettier': 'error', | ||
// Note regarding rule severity, the available values are: | ||
// 'off' or 0 - turn the rule off | ||
// 'warn' or 1 - turn the rule on as a warning (doesn't effect exit code) | ||
// 'error' or 2 - turn the rule on as an error (exit code is 1 when triggered) | ||
//------------------------------------------------------------------------------------------- | ||
'import/no-extraneous-dependencies': 0, | ||
'import/no-named-as-default': 0, | ||
'no-console': 1, | ||
'spaced-comment': [ | ||
'error', | ||
'always', | ||
{ | ||
exceptions: ['=', '-'], | ||
}, | ||
], | ||
|
||
indent: 'off', | ||
'@typescript-eslint/indent': ['error', 2], | ||
}, | ||
}; |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,61 +1,74 @@ | ||
# Contributing | ||
When contributing to this repository, please first discuss the change you wish to make by creating | ||
an issue. Please note we have a code of conduct. Please follow it in all your interactions | ||
with the project. | ||
|
||
When contributing to this repository, please first discuss the change you wish | ||
to make by creating an issue. Please note we have a code of conduct. Please | ||
follow it in all your interactions with the project. | ||
|
||
## Pull Request Process | ||
* Create a fork of this repository, then clone the fork to your local development environment: `git clone https://github.com/YOUR_USERNAME/styled-components-modifiers.git` | ||
* Create a branch with a meaningful name reflecting the bug fix or new feature: `git checkout -b my-new-feature` | ||
* Make your changes (including updates/additions to tests) and commit: `git add` and `git commit` | ||
* Make sure that the tests still pass: `npm run review` | ||
* Push your branch: `git push -u origin my-new-feature` | ||
* [Submit a pull request](https://github.com/Decisiv/styled-components-modifiers/compare) to the upstream `styled-components-modifiers` repository. | ||
* Enter a descriptive title for the pull request and fill in the PR template, describing the proposed changes. | ||
* Wait for a maintainer to review your PR. Follow up on any comments from the reviewer, and wait for a maintainer to merge the PR. | ||
|
||
- Create a fork of this repository, then clone the fork to your local | ||
development environment: | ||
`git clone https://github.com/YOUR_USERNAME/styled-components-modifiers.git` | ||
- Create a branch with a meaningful name reflecting the bug fix or new feature: | ||
`git checkout -b my-new-feature` | ||
- Make your changes (including updates/additions to tests) and commit: `git add` | ||
and `git commit` | ||
- Make sure that the tests still pass: `yarn run review` | ||
- Push your branch: `git push -u origin my-new-feature` | ||
- [Submit a pull request](https://github.com/Decisiv/styled-components-modifiers/compare) | ||
to the upstream `styled-components-modifiers` repository. | ||
- Enter a descriptive title for the pull request and fill in the PR template, | ||
describing the proposed changes. | ||
- Wait for a maintainer to review your PR. Follow up on any comments from the | ||
reviewer, and wait for a maintainer to merge the PR. | ||
|
||
## Contributor Covenant Code of Conduct | ||
|
||
### Our Pledge | ||
|
||
In the interest of fostering an open and welcoming environment, we as | ||
contributors and maintainers pledge to making participation in our project and | ||
our community a harassment-free experience for everyone, regardless of age, body | ||
size, disability, ethnicity, gender identity and expression, level of experience, | ||
nationality, personal appearance, race, religion, or sexual identity and | ||
orientation. | ||
size, disability, ethnicity, gender identity and expression, level of | ||
experience, nationality, personal appearance, race, religion, or sexual identity | ||
and orientation. | ||
|
||
### Our Standards | ||
|
||
Examples of behavior that contributes to creating a positive environment | ||
include: | ||
|
||
* Using welcoming and inclusive language | ||
* Being respectful of differing viewpoints and experiences | ||
* Gracefully accepting constructive criticism | ||
* Focusing on what is best for the community | ||
* Showing empathy towards other community members | ||
- Using welcoming and inclusive language | ||
- Being respectful of differing viewpoints and experiences | ||
- Gracefully accepting constructive criticism | ||
- Focusing on what is best for the community | ||
- Showing empathy towards other community members | ||
|
||
Examples of unacceptable behavior by participants include: | ||
|
||
* The use of sexualized language or imagery and unwelcome sexual attention or | ||
advances | ||
* Trolling, insulting/derogatory comments, and personal or political attacks | ||
* Public or private harassment | ||
* Publishing others' private information, such as a physical or electronic | ||
- The use of sexualized language or imagery and unwelcome sexual attention or | ||
advances | ||
- Trolling, insulting/derogatory comments, and personal or political attacks | ||
- Public or private harassment | ||
- Publishing others' private information, such as a physical or electronic | ||
address, without explicit permission | ||
* Other conduct which could reasonably be considered inappropriate in a | ||
- Other conduct which could reasonably be considered inappropriate in a | ||
professional setting | ||
|
||
### Our Responsibilities | ||
|
||
Project maintainers are responsible for clarifying the standards of acceptable | ||
behavior and are expected to take appropriate and fair corrective action in | ||
response to any instances of unacceptable behavior. | ||
|
||
Project maintainers have the right and responsibility to remove, edit, or | ||
reject comments, commits, code, wiki edits, issues, and other contributions | ||
that are not aligned to this Code of Conduct, or to ban temporarily or | ||
permanently any contributor for other behaviors that they deem inappropriate, | ||
threatening, offensive, or harmful. | ||
Project maintainers have the right and responsibility to remove, edit, or reject | ||
comments, commits, code, wiki edits, issues, and other contributions that are | ||
not aligned to this Code of Conduct, or to ban temporarily or permanently any | ||
contributor for other behaviors that they deem inappropriate, threatening, | ||
offensive, or harmful. | ||
|
||
### Scope | ||
|
||
This Code of Conduct applies both within project spaces and in public spaces | ||
when an individual is representing the project or its community. Examples of | ||
representing a project or community include using an official project e-mail | ||
|
@@ -64,20 +77,22 @@ representative at an online or offline event. Representation of a project may be | |
further defined and clarified by project maintainers. | ||
|
||
### Enforcement | ||
|
||
Instances of abusive, harassing, or otherwise unacceptable behavior may be | ||
reported by contacting the project team [email protected]. All | ||
complaints will be reviewed and investigated and will result in a response that | ||
is deemed necessary and appropriate to the circumstances. The project team is | ||
obligated to maintain confidentiality with regard to the reporter of an incident. | ||
Further details of specific enforcement policies may be posted separately. | ||
reported by contacting the project team [email protected]. All complaints will be | ||
reviewed and investigated and will result in a response that is deemed necessary | ||
and appropriate to the circumstances. The project team is obligated to maintain | ||
confidentiality with regard to the reporter of an incident. Further details of | ||
specific enforcement policies may be posted separately. | ||
|
||
Project maintainers who do not follow or enforce the Code of Conduct in good | ||
faith may face temporary or permanent repercussions as determined by other | ||
members of the project's leadership. | ||
|
||
### Attribution | ||
This Code of Conduct is adapted from the [Contributor Covenant][homepage], version 1.4, | ||
available at [http://contributor-covenant.org/version/1/4][version] | ||
|
||
This Code of Conduct is adapted from the [Contributor Covenant][homepage], | ||
version 1.4, available at [http://contributor-covenant.org/version/1/4][version] | ||
|
||
[homepage]: http://contributor-covenant.org | ||
[version]: http://contributor-covenant.org/version/1/4/ |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,14 +1,15 @@ | ||
## EXPECTED BEHAVIOR | ||
|
||
_What's the behavior you're expecting to see?_ | ||
|
||
## ACTUAL BEHAVIOR | ||
|
||
_What's actually happening instead?_ | ||
|
||
## STEPS TO REPRODUCE | ||
_Please provide some simple steps to reproduce the issue._ | ||
* | ||
* | ||
* | ||
|
||
_Please provide some simple steps to reproduce the issue._ \* \* \* | ||
|
||
## SUGGESTED SOLUTION | ||
|
||
_Do you have any feedback on how this problem should be solved?_ |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,22 +1,28 @@ | ||
## OVERVIEW | ||
|
||
_Give a brief description of what this PR does._ | ||
|
||
## WHERE SHOULD THE REVIEWER START? | ||
|
||
_e.g. `/src/components/SomeComponent.js`_ | ||
|
||
## HOW CAN THIS BE MANUALLY TESTED? | ||
|
||
_List steps to test this locally._ | ||
|
||
## ANY NEW DEPENDENCIES ADDED? | ||
|
||
_List any new dependencies added._ | ||
|
||
## CHECKLIST | ||
|
||
_Be sure all items are_ ✅ _before submitting a PR for review._ | ||
* [ ] Verify the linter and tests pass: `npm run review` | ||
* [ ] Verify this branch is rebased with the latest master | ||
|
||
- [ ] Verify the linter and tests pass: `npm run review` | ||
- [ ] Verify this branch is rebased with the latest master | ||
|
||
## GIF | ||
_Share a fun GIF to say thanks to your reviewer:_ | ||
https://giphy.com | ||
|
||
_Share a fun GIF to say thanks to your reviewer:_ https://giphy.com | ||
|
||
![](https://media.giphy.com/media/xTiTnfkt9wCx4fuWhW/giphy.gif) |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,5 +1,5 @@ | ||
coverage | ||
lib | ||
src | ||
.babelrc | ||
.eslintrc | ||
.github | ||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,6 @@ | ||
**-lock.json | ||
*.tsbuildinfo | ||
coverage | ||
lib/** | ||
node_modules | ||
tmp |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,10 @@ | ||
{ | ||
"arrowParens": "always", | ||
"bracketSpacing": true, | ||
"printWidth": 80, | ||
"proseWrap": "always", | ||
"singleQuote": true, | ||
"tabWidth": 2, | ||
"trailingComma": "all" | ||
} | ||
|
Oops, something went wrong.