Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Configurable headers+QoL #4

Open
wants to merge 26 commits into
base: master
Choose a base branch
from
Open

Conversation

will-rigney
Copy link

In progress RF + new features added to DDMock.

Still todo: usability & quality updates, documentation + tests.

@will-rigney will-rigney requested a review from tplester June 17, 2021 04:14
# To learn more about a Podspec see https://guides.cocoapods.org/syntax/podspec.html
#

Pod::Spec.new do |spec|
spec.name = 'DDMockiOS'
spec.version = '0.1.5'
spec.version = '2.0'
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

0.1 to 2.0 is a pretty big jump

Copy link
Contributor

@tplester tplester left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The url for Cocoapod needs to be reverted, otherwise looks ok.

spec.license = { :type => 'MIT', :file => 'LICENSE' }
spec.author = 'Deloitte Digital Asia Pacific'
spec.source = { :git => "https://github.com/DeloitteDigitalAPAC/ddmock-ios.git", :tag => 'v' + spec.version.to_s }
spec.source = { :git => "https://github.com/will-rigney/ddmock-ios.git", :tag => 'v' + spec.version.to_s }
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This needs to be set back to the right url

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants