Bug fixes: anticipating None values

[ioana-istrate-ciobanu]

Anticipating None values. Before, we were getting errors.

[sonarcloud]

Kudos, SonarCloud Quality Gate passed!   

0 Bugs
0 Vulnerabilities
0 Security Hotspots
0 Code Smells

No Coverage information
No Duplication information

[ioana-istrate-ciobanu]

If one CPT misses some or the entire required data, it shouldn't get populated with the data from the previously read CPT.

Test 1 - The first CPT contains data, but it is not read. Then, the second CPT does not get populated with data.

from geolib_plus.bro_xml_cpt import BroXmlCpt
import os
from pathlib import Path
out_dir = r""

cpt_xml1 = os.path.join(out_dir,"CPT000000038970"+".xml")
cpt_xml2 = os.path.join(out_dir,'CPT000000089280'+".xml")
# cpt_data1 = BroXmlCpt()
# cpt_data1.read(Path(cpt_xml1))

cpt_data2 = BroXmlCpt()
cpt_data2.read(Path(cpt_xml2))

# print(f"cpt_data1.depth {cpt_data1.depth is None}")
print(f"cpt_data2.depth {cpt_data2.depth is None}")

Output:

Backend TkAgg is interactive backend. Turning interactive mode on.
WARNING:root:CPT with id CPT000000089280 misses required data.
cpt_data2.depth True

Test 2 - The first CPT contains data and it is read. Because of that, the second CPT - which is supposed to be empty, gets populated with data.

from geolib_plus.bro_xml_cpt import BroXmlCpt
import os
from pathlib import Path
out_dir = r""

cpt_xml1 = os.path.join(out_dir,"CPT000000038970"+".xml")
cpt_xml2 = os.path.join(out_dir,'CPT000000089280'+".xml")
cpt_data1 = BroXmlCpt()
cpt_data1.read(Path(cpt_xml1))

cpt_data2 = BroXmlCpt()
cpt_data2.read(Path(cpt_xml2))

print(f"cpt_data1.depth {cpt_data1.depth is None}")
print(f"cpt_data2.depth {cpt_data2.depth is None}")

Output

Backend TkAgg is interactive backend. Turning interactive mode on.
WARNING:root:CPT with id CPT000000089280 misses required data.
cpt_data1.depth False
cpt_data2.depth False

[EleniSmyrniou]

Could you add the code you appended above as a unit test?

[EleniSmyrniou]

Thanks for your changes and writing a unit test!
I noticed you are using the unittest package.
In geolib-plus we are using pytest so I made some comments in the code on which lines need to be changed

[sonarcloud]

Kudos, SonarCloud Quality Gate passed!   

0 Bugs
0 Vulnerabilities
0 Security Hotspots
0 Code Smells

No Coverage information
No Duplication information