Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

598 adaptation calculate impact adaptation option for time horizon #617

Conversation

MatthiasHauthDeltares
Copy link
Contributor

@MatthiasHauthDeltares MatthiasHauthDeltares commented Dec 3, 2024

Issue addressed

Solves #598

Code of conduct

  • I HAVE NOT added sensitive or compromised (test) data to the repository.
  • I HAVE NOT added vulnerabilities to the repository.
  • I HAVE discussed my solution with (other) members of the RA2CE team.

What has been done?

Explain how you addressed the resolution of the related issue, what choices you made and why.

Checklist

  • Code is formatted using our custom black and isort definitions.
  • Tests are either added or updated.
  • Branch is up to date with master.
  • Updated documentation if needed.

Additional Notes (optional)

Add any additional notes or information that may be helpful.

@MatthiasHauthDeltares MatthiasHauthDeltares marked this pull request as draft December 3, 2024 12:59
@MatthiasHauthDeltares MatthiasHauthDeltares marked this pull request as ready for review December 6, 2024 09:28
Copy link
Collaborator

@Carsopre Carsopre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor remark on the test side.

ra2ce/analysis/adaptation/adaptation_option.py Outdated Show resolved Hide resolved
Copy link
Collaborator

@Carsopre Carsopre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Apply required change in adaptation_option.py, otherwise the build will fail.

@MatthiasHauthDeltares MatthiasHauthDeltares merged commit 9096b12 into master Dec 6, 2024
4 checks passed
@MatthiasHauthDeltares MatthiasHauthDeltares deleted the 598-adaptation-calculate-impact-adaptation-option-for-time-horizon branch December 6, 2024 14:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Adaptation: Calculate impact adaptation option for time horizon
2 participants