-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
598 adaptation calculate impact adaptation option for time horizon #617
Merged
MatthiasHauthDeltares
merged 17 commits into
master
from
598-adaptation-calculate-impact-adaptation-option-for-time-horizon
Dec 6, 2024
Merged
598 adaptation calculate impact adaptation option for time horizon #617
MatthiasHauthDeltares
merged 17 commits into
master
from
598-adaptation-calculate-impact-adaptation-option-for-time-horizon
Dec 6, 2024
+46
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Carsopre
requested changes
Dec 6, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Minor remark on the test side.
Co-authored-by: Carles S. Soriano Pérez <[email protected]>
Co-authored-by: Carles S. Soriano Pérez <[email protected]>
…-option-for-time-horizon
…adaptation-option-for-time-horizon' into 598-adaptation-calculate-impact-adaptation-option-for-time-horizon
Carsopre
reviewed
Dec 6, 2024
Carsopre
approved these changes
Dec 6, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Apply required change in adaptation_option.py
, otherwise the build will fail.
MatthiasHauthDeltares
deleted the
598-adaptation-calculate-impact-adaptation-option-for-time-horizon
branch
December 6, 2024 14:05
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue addressed
Solves #598
Code of conduct
What has been done?
Explain how you addressed the resolution of the related issue, what choices you made and why.
Checklist
black
andisort
definitions.master
.Additional Notes (optional)
Add any additional notes or information that may be helpful.