-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feat/622 adaptation calculate full link cost #623
Merged
Merged
+35
−17
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…d-reader' into feat/592-adaptation-create-class-adaptationoptioncollection
…d-reader' into feat/592-adaptation-create-class-adaptationoptioncollection
…d-reader' of https://github.com/Deltares/ra2ce into feat/604-adaptation-extend-analysis-config-dataclass-and-reader
…d-reader' into feat/592-adaptation-create-class-adaptationoptioncollection
…d-reader' into feat/592-adaptation-create-class-adaptationoptioncollection
…noptioncollection
… of https://github.com/Deltares/ra2ce into feat/595-adaptation-run-and-combine-losses-and-damages
ArdtK
changed the base branch from
master
to
feat/595-adaptation-run-and-combine-losses-and-damages
December 4, 2024 09:43
… into feat/622-adaptation-calculate-full-link-cost
MatthiasHauthDeltares
approved these changes
Dec 5, 2024
Base automatically changed from
feat/595-adaptation-run-and-combine-losses-and-damages
to
master
December 5, 2024 17:30
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue addressed
Solves #622
Code of conduct
What has been done?
Instead of adding the (constant) unit cost to the gdf for each adaptation option add the calculated link cost per adaptation option.
Checklist
black
andisort
definitions.master
.Additional Notes (optional)
Add scope to the fixture to reduce test run time.