Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Generate Component Template and template path #27

Open
wants to merge 12 commits into
base: master
Choose a base branch
from

Conversation

JonnoKiwi
Copy link
Collaborator

Closing #22

@trafico-bot trafico-bot bot added the 🔍 Ready for Review Pull Request is not reviewed yet label Oct 16, 2020
@JonnoKiwi JonnoKiwi marked this pull request as draft October 16, 2020 22:14
@JonnoKiwi JonnoKiwi changed the title editing template path and component template Generate Component Template and template path Oct 16, 2020
@trafico-bot trafico-bot bot added ⚠️ Changes requested Pull Request needs changes before it can be reviewed again and removed 🔍 Ready for Review Pull Request is not reviewed yet labels Oct 20, 2020
@trafico-bot trafico-bot bot added 🔍 Ready for Review Pull Request is not reviewed yet and removed ⚠️ Changes requested Pull Request needs changes before it can be reviewed again labels Oct 20, 2020
@JonnoKiwi JonnoKiwi marked this pull request as ready for review October 20, 2020 01:23
Copy link
Contributor

@johntimothybailey johntimothybailey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please write tests like we did for the Screen generator

@trafico-bot trafico-bot bot added ⚠️ Changes requested Pull Request needs changes before it can be reviewed again and removed 🔍 Ready for Review Pull Request is not reviewed yet ⚠️ Changes requested Pull Request needs changes before it can be reviewed again labels Oct 30, 2020
@trafico-bot trafico-bot bot added the 🔍 Ready for Review Pull Request is not reviewed yet label Dec 7, 2020
@todo
Copy link

todo bot commented Dec 9, 2020

There is no difference if you select with or without Mobx. Component Generator behave differently if Mobx is selected.

//TODO There is no difference if you select with or without Mobx. Component Generator behave differently if Mobx is selected.
/*
const selectWithMobx = async io => {
await sendKeystrokes(async () => {
// Move pass Navigation without making a selection
io.send('y')


This comment was generated by todo based on a TODO comment in c51a14e in #27. cc @DelveFore.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🔍 Ready for Review Pull Request is not reviewed yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants