Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hotfix/ec emblem import #2343

Closed
wants to merge 1 commit into from
Closed

Conversation

VirginiaDooley
Copy link
Contributor

@VirginiaDooley VirginiaDooley commented Jun 3, 2024

Peter reported that the logo hadn't updated to match the EC register: https://whocanivotefor.co.uk/parties/party:17545/party-of-women

I checked the import-parties job on WCIVF and it was running as expected.

I moved to YNR to debug and found that the emblem wasn't updating bc the id had not changed and an emblem version history did not exist. I added a way to update the emblem when only one image exists on the register.

To test this,
run the local server and visit the endpoint for api/next/parties/PP17545/
Click the s3 image link and notice the old logo

run the command for the ec importer and refresh:
python manage.py parties_import_from_ec

The logo should match the one shown here:
https://search.electoralcommission.org.uk/English/Registrations/PP17545


@VirginiaDooley VirginiaDooley requested a review from symroe June 3, 2024 12:17
@VirginiaDooley VirginiaDooley force-pushed the hotfix/ec-emblem-import branch from 96d8450 to 2d57724 Compare June 3, 2024 12:18
@VirginiaDooley
Copy link
Contributor Author

Upon further discussion with the team, the fix for this issue needs a more comprehensive rehaul. In the interim, @symroe is going to run a full import to replace all emblems.

A more comprehensive overhaul might involve checking the hash of the saved file against the remote one.

FYI, the deadline for having an emblem on the ballot is 4pm on 7 June . After that, the emblem cannot be on the ballot/used for the GE. That said, it's ok to continue importing emblem changes to our site. The scheduled job will keep running once daily, but this bug will remain until we overhaul/do manual full import.

@VirginiaDooley VirginiaDooley removed the request for review from symroe June 4, 2024 08:26
@VirginiaDooley
Copy link
Contributor Author

Ref #2353

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant