Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Peter reported that the logo hadn't updated to match the EC register: https://whocanivotefor.co.uk/parties/party:17545/party-of-women
I checked the
import-parties
job on WCIVF and it was running as expected.I moved to YNR to debug and found that the emblem wasn't updating bc the id had not changed and an emblem version history did not exist. I added a way to update the emblem when only one image exists on the register.
To test this,
run the local server and visit the endpoint for
api/next/parties/PP17545/
Click the s3 image link and notice the old logo
run the command for the ec importer and refresh:
python manage.py parties_import_from_ec
The logo should match the one shown here:
https://search.electoralcommission.org.uk/English/Registrations/PP17545