Fix: allow operator and violationState to be specified when create policy #2997
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…licy Signed-off-by: 久米 拓馬 <[email protected]>
takumakume
changed the title
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Allow
operatorandviolationStateto be specified when create policy.In addition, to keep backward compatibility, default values are provided.
Addressed Issue
Closes #2365
The
violationStateis problematic, but so is theoperator.Additional Details
Currently, sending the
operatorandviolationStateparameters is ignored and the hard-coded values are used.If these are to be changed to other values, a policy update is required, which is inefficient.
This is a problem specific to create policy since it is a required parameter in the model layer.
In order to maintain backward compatibility of create policy, a default value has been added.
Checklist
This PR implements an enhancement, and I have provided tests to verify that it works as intendedThis PR introduces changes to the database model, and I have added corresponding update logicThis PR introduces new or alters existing behavior, and I have updated the documentation accordingly