fix: breadcrumbs navigation broken for non-english language #1066
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
coreui/vue breadcrumbs takes name as the name the component to redirect to from the router and label to display the name in UI, since only name was provided it would display that name and use that as the component, and as the components are constant values in the Router config, it was causing not found issue Signed-off-by: idrisGit <[email protected]>
nscuro
added
defect
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
coreui/vue breadcrumbs take the name prop as the name of the component to redirect to and label to display the name in UI, since only the name prop was provided it would display that name and use that as the component name.
Since the component names are constant values in English in the Router config, it was causing a not-found issue for languages other than English. The router was not able to find components for those labels, as they were non-existent, causing the router to break.
In this change, I have added the sectionName as a constant value to be used in the name prop and i18n translation for the label prop in the breadcrumbs.
Addressed Issue
Fixes #880
Additional Details
I have used this approach as it is a good practice to keep the component and route names a constant value and only use i18n for the display label, as translations can change over time and we don't want to deal with constant updates, using constant values helps keep things organised.
Checklist
This PR introduces new or alters existing behavior, and I have updated the documentation accordingly