Add compass rose and work around wasm crash #64
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…imilar information
oli-obk
commented
Dec 8, 2023
src/lib.rs
Outdated
Comment on lines
303
to
310
| player: Player, | ||
| ) { | ||
| if let Ok((mut pos, mut grid)) = compass.get_single_mut() { | ||
| let player = player.pos(); | ||
| let directions = player.directions(); | ||
| pos.translation = player.transform.translation - directions.up * 5.; | ||
| *grid = player.grid; | ||
| pos.look_to(directions.north, directions.up) |
There was a problem hiding this comment.
@DerKarlos I added a helper that wraps all the annoying math in a nice function and gives you a struct with a north, up, and west vector (all orthogonal to each other).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
wasm failed to load the cloud and earth textures, and then crashed. Now we fail gracefully. But I also embedded the textures directly into the binary, so we don't need to download them.
We should figure out how to add a loading bar for downloading the wasm blob, because that's 60 MB now 😆
fixes #63
fixes #51