Updated Cascade to build with spdlog 1.12 #77
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The next version of Derecho will depend on spdlog 1.12 instead of spdlog 1.9.2, and this library update introduced breaking changes. A few new lines of code are needed to allow Cascade to compile against the Derecho version that uses spdlog 1.12, and Cascade's own CMakeLists should specify that it expects the newer spdlog version (since it will no longer compile against spdlog 1.9.2 with these changes).
Now that the spdlog updates are in version 2.4.1 of Derecho, the README should say that the current version of Cascade requires Derecho 2.4.1. Also, when writing the package config file, we should use the "full" version (cascade_build_VERSION) for the VERSION property to make sure the patch level is included, as documented here: https://cmake.org/cmake/help/latest/module/CMakePackageConfigHelpers.html#generating-a-package-version-file
|
Note: Just like in the related Derecho PR (283), the build check "failed" on this because the |
tgarr
approved these changes
Nov 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The next version of Derecho will depend on spdlog 1.12 instead of spdlog 1.9.2, and this library update introduced breaking changes. A few new lines of code are needed to allow Cascade to compile against the Derecho version that uses spdlog 1.12, and Cascade's own CMakeLists should specify that it expects the newer spdlog version (since it will no longer compile against spdlog 1.9.2 with these changes). Once there is a Derecho version that uses the new spdlog, we can merge these changes and create a Cascade version that matches the dependency.