Bug fix: Blob copy constructor and BLOB_GENERATOR memory mode #78
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… mode of the object being copied (it would cause a seg fault if the mode was BLOB_GENERATOR)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the Blob copy constructor, if the object being copied has a lambda (instead of a plain buffer), i.e. BLOB_GENERATOR memory mode, the constructor tries to copy from an empty buffer, causing a Segmentation Fault.
The issue is just that the code is checking
memory_modefrom the new object (which is always DEFAULT), not on the other object (that is being copied).So it's a very simple fix, I'm merging it to master right away.