Improvements for gzip sending #278
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… seconds halting when the buffer has no data
…for-gzip-sending Feature/improvements for gzip sending
|
|
feat: add lock to fill_buffer function
…for-gzip-sending feature/improvements-for-gzip-sending
angel-devo
reviewed
Jun 11, 2024
angel-devo
reviewed
Jun 11, 2024
…for-gzip-sending feat: buffer setter for emergency system
…nding' into feature/improvements-for-gzip-sending
…for-gzip-sending Applied changes suggested by reviewer
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These changes add a thread (SenderBufferFlusher) for controlling the flushing of the buffer used when sending using Gzip.
The SenderBuffer class has been modified a bit but these changes don't affect the current functionality.
The usage of this SenderBufferFlusher thread is optional and by default, it will not be used.