Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP: IMCA Shipments #136

Closed
wants to merge 40 commits into from
Closed

WIP: IMCA Shipments #136

wants to merge 40 commits into from

Conversation

stufisher
Copy link
Contributor

@stufisher stufisher commented Aug 22, 2020

Adds:

  • Generic profile based CSV importer see imca.js
  • Mobile container assigner based on barcode scanning
  • Ability to show diffraction plan columns when registering a container (show DP columns)

And the two db changes:
DiamondLightSource/ispyb-database#46

DiamondLightSource/ispyb-database#43
DiamondLightSource/ispyb-database#47

@stufisher stufisher requested a review from drnasmith August 30, 2020 07:43
@jlmuir
Copy link
Contributor

jlmuir commented Apr 20, 2021

If I want to export a shipment to CSV from the Shipment view, I have to click the "Import from CSV" button which takes me to the "Import from CSV" view where there is an "Export to CSV" button that I can press. This is not intuitive (i.e., clicking the "import" button when I want to "export"). It would be better if there were another button on the Shipment view called "Export to CSV" right next to the "Import from CSV" button. Or maybe easier would be to change the label of the "Import from CSV" button to "Import/Export CSV" or "CSV Import/Export"? Or maybe some other approach that I haven't thought of.

shipment-import-from-csv-button

@stufisher
Copy link
Contributor Author

If I want to export a shipment to CSV from the Shipment view, I have to click the "Import from CSV" button which takes me to the "Import from CSV" view where there is an "Export to CSV" button that I can press. This is not intuitive (i.e., clicking the "import" button when I want to "export"). It would be better if there were another button on the Shipment view called "Export to CSV" right next to the "Import from CSV" button. Or maybe easier would be to change the label of the "Import from CSV" button to "Import/Export CSV" or "CSV Import/Export"? Or maybe some other approach that I haven't thought of.

shipment-import-from-csv-button

Resolved in 3feb552

STATUS: function(m) {
var status = 'skipped'
if (m.QUEUEDTIMESTAMP) status = 'queued';
if (m.R > 0) status = 'recieved'
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a typo: recieved should be received.

@ndg63276
Copy link
Collaborator

@stufisher - can this PR be closed? It looks like #239 supersedes it?

@gfrn gfrn closed this Sep 23, 2024
@gfrn gfrn deleted the feature/imca_shipments branch September 23, 2024 08:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants