Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

LIMS-1125: Prompt user login on shipping service 401 status #694

Merged
merged 1 commit into from
Nov 23, 2023
Merged

LIMS-1125: Prompt user login on shipping service 401 status #694

merged 1 commit into from
Nov 23, 2023

Conversation

MattPrit
Copy link
Contributor

JIRA ticket: LIMS-1125

Summary:

If the shipping service returns a 401 when a user attempts to book an incoming shipment (due to an expired token), prompt the user to log in again.

Changes:

  • Return errors received from the shipping service to the frontend when trying to book an incoming shipment.

To test:

  • Check that shipping service error statuses and content details are returned to the client from the backend. In particular, check that a 401 error code results in the user being prompted to log in again.

@MattPrit MattPrit requested a review from gfrn November 22, 2023 13:00
@MattPrit MattPrit self-assigned this Nov 22, 2023
@NKatti2011 NKatti2011 merged commit d1535b8 into prerelease Nov 23, 2023
2 checks passed
@ndg63276 ndg63276 deleted the fix/lims-1125/login-redirect-on-shipping-auth-failure branch December 5, 2023 09:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gfrn gfrn gfrn approved these changes

Assignees

@MattPrit MattPrit

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@MattPrit @gfrn @NKatti2011