LIMS-1170: Don't use thumbnails of crystal snapshot images

[benjaminhwilliams]

JIRA ticket: LIMS-1170

Summary:

Use full-sized crystal snapshot image files, not thumbnails.

Note that I have only touched the crystal snapshot image handling, not the diffraction preview image handling, which also uses a thumbnail image, which is generated upstream by a different mechanism to the snapshot image thumbnails.

Changes:

• Remove ternary operation to switch between reading the full-sized image and the thumbnail. Always use the full-sized image.

To test:

• Find a data collection that has multiple image snapshots (each DC can have up to four).
• Open all views that display a data collection pane. Check that the snapshot image is displayed correctly.
• Click on the snapshot image. Check that you can still roll through the full selection of available snapshot images.
• Repeat the above for a robot load pane.

[benjaminhwilliams]

@ndg63276, sorry, I dropped this earlier. Can I add you as a reviewer or, alternatively, could you nominate someone suitable? And/or, could you provide guidance on testing this myself?

[ndg63276]

Happy to have a look at it. Everything seems to work, but given that we are removing the use of the 'f' flag in data collection/robot action snapshot requests, can we get rid of the "/f/1" in lots of places?

ie the result of grep 'image/id\|image/ai' -r client/src/js/* | grep "/f/1"

[ndg63276]

Given that we are removing the use of the 'f' flag in data collection/robot action snapshot requests, can we get rid of the "/f/1" in lots of places?

[benjaminhwilliams]

Thanks for the prod, @ndg63276, I agree and I'll make it happen ASAP.

[ndg63276]

Superseded by #784